-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
constexpr for Hcal Calib and Cond #23579
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23579/5175 |
A new Pull Request was created by @vkhristenko (Viktor Khristenko) for master. It involves the following packages: CalibFormats/HcalObjects @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @pohsun, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@vkhristenko Although there's no compilation error in the log, AFAIK, non-empty constructor with constexpr is supported since c++14. Do you know which c++ standard are we using? As a newbie in code review, I just want to learn more. |
We are using c++17, with partial support in GCC 6.x and more full support
in GCC 7.x .
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
adding constexpr to
only for these 2 in order to keep changes minimal for hcal reco at this point
https://github.com/cms-sw/cmssw/blob/master/RecoLocalCalo/HcalRecProducers/src/HBHEPhase1Reconstructor.cc#L547
reco_->reconstruct
needs only these 2, the rest sits in theHBHEChannelInfo
that has been accomodated via #23495