constexpr for Hcal Calib and Cond

[vkhristenko]

adding constexpr to

• HcalCalibrations
• HcalRecoParam

only for these 2 in order to keep changes minimal for hcal reco at this point
https://github.com/cms-sw/cmssw/blob/master/RecoLocalCalo/HcalRecProducers/src/HBHEPhase1Reconstructor.cc#L547
reco_->reconstruct needs only these 2, the rest sits in the HBHEChannelInfo that has been accomodated via #23495

[vkhristenko]

fyi @fwyzard , @makortel

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23579/5175

[cmsbuild]

A new Pull Request was created by @vkhristenko (Viktor Khristenko) for master.

It involves the following packages:

CalibFormats/HcalObjects
CondFormats/HcalObjects

@arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28672/console Started: 2018/06/13 15:13

[cmsbuild]

+1
Tested at: 9994068
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23579/28672/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23579/28672/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902004
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901812
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[pohsun]

@vkhristenko Although there's no compilation error in the log, AFAIK, non-empty constructor with constexpr is supported since c++14. Do you know which c++ standard are we using? As a newbie in code review, I just want to learn more.

[fwyzard]

We are using c++17, with partial support in GCC 6.x and more full support in GCC 7.x .

[pohsun]

+1

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1