adding displacedStandAlone muon collection to miniaod #23591

vinzenzstampf · 2018-06-14T16:30:36Z

following our request of the xpog meeting of May 28 by @dehuazhu and the approval by the conveners @arizzi and @gpetruc of June 8 (https://hypernews.cern.ch/HyperNews/CMS/get/exotica-longlived/532/2.html)  we submit our pull request to include the 'displacedStandAlone' muon collection
in the miniaod

a heads-up: we’re not entirely sure, that this is the only file that needs to be changed

riccardo manzoni, vinzenz stampf, dehua zhu

cmsbuild · 2018-06-14T16:30:54Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-14T16:33:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23591/5191

cmsbuild · 2018-06-14T16:33:33Z

A new Pull Request was created by @vinzenzstampf for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@HeinerTholen, @TaiSakuma, @gouskos, @rappoccio, @jdolen, @imarches, @ahinzmann, @smoortga, @acaudron, @gpetruc, @mmarionncern, @jdamgov, @JyothsnaKomaragiri, @nhanvtran, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2018-06-14T16:47:07Z

@cmsbuild please test

cmsbuild · 2018-06-14T16:47:23Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28700/console Started: 2018/06/14 18:47

cmsbuild · 2018-06-14T19:34:13Z

+1
Tested at: a01809e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23591/28700/summary.html

cmsbuild · 2018-06-14T19:34:16Z

Comparison job queued.

cmsbuild · 2018-06-14T21:00:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23591/28700/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2902004
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901813
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

slava77 · 2018-06-15T17:20:56Z

PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py

-        'keep CTPPSLocalTrackLites_ctppsLocalTrackLiteProducer_*_*'
+        'keep CTPPSLocalTrackLites_ctppsLocalTrackLiteProducer_*_*',
+	# displacedStandAlone muon collection for EXO
+	'keep recoTracks_displacedStandAloneMuons_*_*',


this will actually pick up recoTracks_displacedStandAloneMuons__ and recoTracks_displacedStandAloneMuons_UpdatedAtVtx_ .
The latter is not saved in production/reco.
Based on your slides https://indico.cern.ch/event/731976/contributions/3022385/attachments/1657880/2654757/180528_zhud_V2.pdf I think that this should be 'keep recoTracks_displacedStandAloneMuons__*'

you're right @slava77 .
@vinzenzstampf can you commit this small change?

cmsbuild · 2018-06-18T09:02:39Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-06-18T09:05:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23591/5219

cmsbuild · 2018-06-18T09:05:43Z

Pull request #23591 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

perrotta · 2018-06-18T09:24:28Z

please test

cmsbuild · 2018-06-18T09:24:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28729/console Started: 2018/06/18 11:25

cmsbuild · 2018-06-18T12:26:24Z

+1
Tested at: 1e41586
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23591/28729/summary.html

cmsbuild · 2018-06-18T12:26:26Z

Comparison job queued.

cmsbuild · 2018-06-18T13:43:09Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23591/28729/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2902013
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901821
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

slava77 · 2018-06-18T15:21:32Z

+1

for #23591 1e41586

implemented as described
jenkins tests pass and the file comparison shows that the new product is added as expected to miniAOD outputs.

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_2_X_2018-06-17-2300+23591/27126/validateJR/logRootQA.log :

250202.181_TTbar_13UP18	step4_inMINIAODSIM.root
    Product added recoTracks_displacedStandAloneMuons__RECO.

fabiocos · 2018-06-18T17:55:15Z

+1

fabiocos · 2018-06-18T17:55:20Z

merge

adding displacedStandAlone muon collection to miniaod

a01809e

cmsbuild added this to the CMSSW_10_2_X milestone Jun 14, 2018

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 14, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 14, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 14, 2018

cmsbuild added tests-approved and removed tests-started labels Jun 14, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jun 14, 2018

slava77 reviewed Jun 15, 2018

View reviewed changes

Update MicroEventContent_cff.py

1e41586

cmsbuild removed code-checks-approved comparison-available tests-approved labels Jun 18, 2018

cmsbuild added code-checks-pending comparison-pending tests-pending labels Jun 18, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 18, 2018

cmsbuild added tests-started and removed tests-pending labels Jun 18, 2018

cmsbuild added tests-approved and removed tests-started labels Jun 18, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jun 18, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 18, 2018

cmsbuild added orp-approved and removed orp-pending labels Jun 18, 2018

cmsbuild merged commit c6efe06 into cms-sw:master Jun 18, 2018

rmanzoni mentioned this pull request Jul 12, 2018

PR to CMSSW on miniAOD content rmanzoni/HNL#6

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding displacedStandAlone muon collection to miniaod #23591

adding displacedStandAlone muon collection to miniaod #23591

vinzenzstampf commented Jun 14, 2018

cmsbuild commented Jun 14, 2018

cmsbuild commented Jun 14, 2018

cmsbuild commented Jun 14, 2018

slava77 commented Jun 14, 2018

cmsbuild commented Jun 14, 2018 •

edited

Loading

cmsbuild commented Jun 14, 2018

cmsbuild commented Jun 14, 2018

cmsbuild commented Jun 14, 2018

slava77 Jun 15, 2018

rmanzoni Jun 18, 2018 •

edited

Loading

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

perrotta commented Jun 18, 2018

cmsbuild commented Jun 18, 2018 •

edited

Loading

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

slava77 commented Jun 18, 2018

fabiocos commented Jun 18, 2018

fabiocos commented Jun 18, 2018

adding displacedStandAlone muon collection to miniaod #23591

adding displacedStandAlone muon collection to miniaod #23591

Conversation

vinzenzstampf commented Jun 14, 2018

cmsbuild commented Jun 14, 2018

cmsbuild commented Jun 14, 2018

cmsbuild commented Jun 14, 2018

slava77 commented Jun 14, 2018

cmsbuild commented Jun 14, 2018 • edited Loading

cmsbuild commented Jun 14, 2018

cmsbuild commented Jun 14, 2018

cmsbuild commented Jun 14, 2018

slava77 Jun 15, 2018

Choose a reason for hiding this comment

rmanzoni Jun 18, 2018 • edited Loading

Choose a reason for hiding this comment

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

perrotta commented Jun 18, 2018

cmsbuild commented Jun 18, 2018 • edited Loading

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

cmsbuild commented Jun 18, 2018

slava77 commented Jun 18, 2018

fabiocos commented Jun 18, 2018

fabiocos commented Jun 18, 2018

cmsbuild commented Jun 14, 2018 •

edited

Loading

rmanzoni Jun 18, 2018 •

edited

Loading

cmsbuild commented Jun 18, 2018 •

edited

Loading