Simplify digi types for HGCal, add dummy unpacker and aliases

[kpedro88]

Followup to #23690.

While we will keep the old digi collection types in order to be able to read previously produced files, from now on all HGCal digis will just store a generic DetId. This is far preferable to adding switches throughout the code to handle the DetId type changes in the new geometry.

attn:
@bsunanda - I propagated this change to the testbeam code, is it acceptable?
@jbsauvan - I propagated this change to the L1T code, let me know if it interferes with anything (hopefully not, just a straightforward changing of types).

Followup:
In order to facilitate reading the old digi types from existing samples to rerun reco/validation sequences, a "dummy" unpacker was added for HGCal, with output type hgcalDigis. The unpacker module can be swapped out with a converter that changes the digi types, using the process modifier convertHGCalDigisReco.

Similarly, to rerun digi/L1 sequences, an EDAlias was added for the simulated digis, simHGCalUnsuppressedDigis. This EDAlias can be swapped out with the same converter module using the process modifier convertHGCalDigisSim.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23703/5357

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28927/console Started: 2018/06/28 01:20

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

DataFormats/HGCDigi
L1Trigger/L1THGCal
RecoLocalCalo/HGCalRecProducers
SimCalorimetry/HGCalSimProducers
SimG4CMS/HGCalTestBeam
Validation/HGCalValidation

@perrotta, @cmsbuild, @civanch, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @kpedro88, @thomreis, @slava77, @vanbesien can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @vandreev11, @sethzenz, @makortel, @felicepantaleo, @rovere, @lgray, @edjtscott, @bsunanda, @cseez, @pfs, @amarini, @jbsauvan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 43e2096
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23703/28927/summary.html

[cmsbuild]

Comparison job queued.

[fabiocos]

@kpedro88 a crash fastsim

in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23703/29106/addOnTests/fastsim1/cmsDriver.py_TTbar_13TeV_TuneCUETP8M1_cfi_--conditions_auto:run2_mc_l1stage1_--fast__-n_100_--eventcontent_AODSIM,DQM_--relval_100000,1000_-s_GEN,SIM,.log

but apparently not in HGCal code...

[kpedro88]

I don't see how it could be caused by this PR... there's no interaction between HGCal and fastsim yet

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23703/29106/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2887250
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2887058
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[kpedro88]

When I ran the same test locally, it did not crash. This makes me suspect memory corruption somewhere. I'm running valgrind on that workflow now. (But again, I don't think it's actually related to this PR.)

[fabiocos]

@kpedro88 I did the same test adding this PR onto this morning IB and got no crash, it could be unrelated, I agree

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29116/console Started: 2018/07/13 22:55

[cmsbuild]

+1
Tested at: eb21a1b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23703/29116/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23703/29116/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2887250
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2887058
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[kpedro88]

valgrind didn't show anything pertinent (though there is a potential memory leak, I'll post an issue).

[fabiocos]

+1

large development affecting HGCal digitization and L1, effects only on Phase2 workflows. Backward compatibility with old production formats provided