-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements and fixes for the BPH-trigger offline DQM code (v2) #23807
Improvements and fixes for the BPH-trigger offline DQM code (v2) #23807
Conversation
…ce - use for pull-request in 10_2_X
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23807/5502 |
A new Pull Request was created by @aboletti for master. It involves the following packages: DQMOffline/Trigger @andrius-k, @kmaeshima, @schneiml, @dmitrijus, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test 136.86 |
please test workflow 136.86 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Same changes that were merged in #23738 and reverted in #23788 after a crash observed in 136.86 (see #23787 ), plus a sanity check to avoid that crash to happen and few additional minor fixes.
The present code has been successfully tested, also on 136.86
Here, for reference, the description of the original PR, listing the major changes to the code:
In this pull-request many features of the offline DQM code used for BPH triggers have been fixed and optimised, and few more functionalities have been added.
Here a list of the major changes: