Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change static to static std::atomic<> for debug and firmwareVersion that... #2383

Merged
merged 1 commit into from Feb 12, 2014
Merged

change static to static std::atomic<> for debug and firmwareVersion that... #2383

merged 1 commit into from Feb 12, 2014

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 10, 2014

... are set once and never changed, make file vars const

…hat are set once and never changed, make file vars const
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_1_X.

change static to static std::atomic<> for debug and firmwareVersion that...

It involves the following packages:

EventFilter/CSCRawToDigi

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@anton-a
Copy link

anton-a commented Feb 11, 2014

+1
e66a1ff
code inspection and jenkins

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 12, 2014
…s-work

Misc fixes -- change static to static std::atomic<> for debug and firmwareVersion that...
@ktf ktf merged commit b87e53e into cms-sw:CMSSW_7_1_X Feb 12, 2014
@gartung gartung deleted the EventFilter-CSCRawToDigi-statics-work branch February 13, 2014 15:59
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
updates geant4 spec file to use latest commit from geant4-external
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants