Always set the thread stack size when configuring TBB, even if the number of threads is not specified (10.2.x) #24055

fwyzard · 2018-07-25T21:51:21Z

Set the thread stack size even if the number of threads is not specified on the command line nor in the process.options ParameterSet.

fwyzard · 2018-07-25T21:52:29Z

backport #24054

fwyzard · 2018-07-25T21:52:32Z

type bugfix

cmsbuild · 2018-07-25T21:53:02Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_10_2_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Backported from Always set the thread stack size when configuring TBB, even if the number of threads is not specified (10.3.x) #24054

fwyzard · 2018-07-25T21:53:02Z

@cmsbuild please test

cmsbuild · 2018-07-25T21:53:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29465/console Started: 2018/07/25 23:53

cmsbuild · 2018-07-26T00:24:26Z

+1
Tested at: 7637daf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24055/29465/summary.html

cmsbuild · 2018-07-26T00:24:29Z

Comparison job queued.

cmsbuild · 2018-07-26T02:31:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24055/29465/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2892290
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2892099
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

cmsbuild · 2018-08-02T14:02:56Z

+1
Tested at: be8488f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24055/29625/summary.html

cmsbuild · 2018-08-02T14:02:59Z

Comparison job queued.

cmsbuild · 2018-08-02T15:09:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24055/29625/summary.html

There are some workflows for which there are errors in the baseline:
250202.181 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 30
DQMHistoTests: Total histograms compared: 2665422
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2665238
DQMHistoTests: Total skipped: 183
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
Checked 125 log files, 11 edm output root files, 30 DQM output files

fabiocos · 2018-08-07T08:57:02Z

please test

cmsbuild · 2018-08-07T08:57:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29705/console Started: 2018/08/07 10:58

cmsbuild · 2018-08-07T10:32:59Z

+1
Tested at: be8488f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24055/29705/summary.html

cmsbuild · 2018-08-07T10:33:04Z

Comparison job queued.

fwyzard · 2018-08-07T11:19:39Z

I think it was successfully tested already last week (and is in 10.3.x for a while now...)

cmsbuild · 2018-08-07T11:43:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24055/29705/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2892884
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2892692
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

fabiocos · 2018-08-07T19:38:11Z

+1

fwyzard changed the base branch from master to CMSSW_10_2_X July 25, 2018 21:51

fwyzard changed the title ~~Configure TBB even if the number of threads is not specified.~~ Configure TBB even if the number of threads is not specified (10.2.x) Jul 25, 2018

cmsbuild added this to the CMSSW_10_2_X milestone Jul 25, 2018

cmsbuild added backport comparison-pending core-pending orp-pending pending-signatures tests-pending labels Jul 25, 2018

cmsbuild added tests-started and removed tests-pending labels Jul 25, 2018

cmsbuild added bug-fix tests-approved and removed tests-started labels Jul 26, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jul 26, 2018

Always set the thread stack size when initialising TBB

0e458dd

fwyzard force-pushed the improve_TBB_setup_102x branch from 7637daf to 0e458dd Compare July 26, 2018 07:12

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jul 26, 2018

cmsbuild added tests-started and removed tests-pending labels Aug 2, 2018

cmsbuild added tests-approved and removed tests-started labels Aug 2, 2018

cmsbuild added comparison-available and removed comparison-pending labels Aug 2, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Aug 7, 2018

cmsbuild added tests-started and removed tests-pending labels Aug 7, 2018

cmsbuild added tests-approved and removed tests-started labels Aug 7, 2018

cmsbuild added comparison-available and removed comparison-pending labels Aug 7, 2018

cmsbuild added orp-approved and removed orp-pending labels Aug 7, 2018

cmsbuild merged commit ac69d9b into cms-sw:CMSSW_10_2_X Aug 7, 2018

fwyzard deleted the improve_TBB_setup_102x branch August 25, 2018 07:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Always set the thread stack size when configuring TBB, even if the number of threads is not specified (10.2.x) #24055

Always set the thread stack size when configuring TBB, even if the number of threads is not specified (10.2.x) #24055

fwyzard commented Jul 25, 2018 •

edited

Loading

fwyzard commented Jul 25, 2018

fwyzard commented Jul 25, 2018 •

edited

Loading

cmsbuild commented Jul 25, 2018 •

edited

Loading

fwyzard commented Jul 25, 2018

cmsbuild commented Jul 25, 2018 •

edited

Loading

cmsbuild commented Jul 26, 2018

cmsbuild commented Jul 26, 2018

cmsbuild commented Jul 26, 2018

cmsbuild commented Aug 2, 2018

cmsbuild commented Aug 2, 2018

cmsbuild commented Aug 2, 2018

fabiocos commented Aug 7, 2018

cmsbuild commented Aug 7, 2018 •

edited

Loading

cmsbuild commented Aug 7, 2018

cmsbuild commented Aug 7, 2018

fwyzard commented Aug 7, 2018

cmsbuild commented Aug 7, 2018

fabiocos commented Aug 7, 2018

Always set the thread stack size when configuring TBB, even if the number of threads is not specified (10.2.x) #24055

Always set the thread stack size when configuring TBB, even if the number of threads is not specified (10.2.x) #24055

Conversation

fwyzard commented Jul 25, 2018 • edited Loading

fwyzard commented Jul 25, 2018

fwyzard commented Jul 25, 2018 • edited Loading

cmsbuild commented Jul 25, 2018 • edited Loading

fwyzard commented Jul 25, 2018

cmsbuild commented Jul 25, 2018 • edited Loading

cmsbuild commented Jul 26, 2018

cmsbuild commented Jul 26, 2018

cmsbuild commented Jul 26, 2018

cmsbuild commented Aug 2, 2018

cmsbuild commented Aug 2, 2018

cmsbuild commented Aug 2, 2018

fabiocos commented Aug 7, 2018

cmsbuild commented Aug 7, 2018 • edited Loading

cmsbuild commented Aug 7, 2018

cmsbuild commented Aug 7, 2018

fwyzard commented Aug 7, 2018

cmsbuild commented Aug 7, 2018

fabiocos commented Aug 7, 2018

fwyzard commented Jul 25, 2018 •

edited

Loading

fwyzard commented Jul 25, 2018 •

edited

Loading

cmsbuild commented Jul 25, 2018 •

edited

Loading

cmsbuild commented Jul 25, 2018 •

edited

Loading

cmsbuild commented Aug 7, 2018 •

edited

Loading