-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add combined premixing workflow for FastSim #24149
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24149/5844 |
@cmsbuild, please test workflow 250402.1 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @prebello, @zhenhu, @kpedro88, @fabozzi, @pgunnell, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please abort Realized, after a more careful look of my test, that the current approach was too simple. |
Jenkins tests are aborted. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24149/5846 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+upgrade |
+1 acc tests approved. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR adds a combined premixing workflow for Fastsim (i.e. what #22956 did for Fullsim). As with #22956, the goal of the workflow is development, PR, and IB level testing of the full chain of changes affecting the premixing stage1. For simplicitly I left the MiniAOD step out because I would have had to duplicate
MINIAODMCUP15FS
for--filein file:step2.root
, and I don't think it is strictly needed for the aforementioned goal (DQM histograms are enough).Tested in 10_2_0, no changes expected in existing workflows.
@kpedro88 @mdhildreth