Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combined premixing workflow for FastSim #24149

Merged
merged 2 commits into from
Aug 6, 2018

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Aug 1, 2018

This PR adds a combined premixing workflow for Fastsim (i.e. what #22956 did for Fullsim). As with #22956, the goal of the workflow is development, PR, and IB level testing of the full chain of changes affecting the premixing stage1. For simplicitly I left the MiniAOD step out because I would have had to duplicate MINIAODMCUP15FS for --filein file:step2.root, and I don't think it is strictly needed for the aforementioned goal (DQM histograms are enough).

Tested in 10_2_0, no changes expected in existing workflows.

@kpedro88 @mdhildreth

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

@makortel
Copy link
Contributor Author

makortel commented Aug 1, 2018

@cmsbuild, please test workflow 250402.1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @prebello, @zhenhu, @kpedro88, @fabozzi, @pgunnell, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @felicepantaleo this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Aug 1, 2018

@cmsbuild, please abort

Realized, after a more careful look of my test, that the current approach was too simple.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Jenkins tests are aborted.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Pull request #24149 was updated. @cmsbuild, @prebello, @zhenhu, @kpedro88, @fabozzi, @pgunnell, @GurpreetSinghChahal can you please check and sign again.

@makortel
Copy link
Contributor Author

makortel commented Aug 1, 2018

@cmsbuild, please test workflow 250402.1

Fixed the input files for the stage2 step similarly to FullSim in #22956 (i.e. in a straightforward, but ugly way).

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29602/console Started: 2018/08/01 15:55

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24149/29602/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24149/250402.1_TTbar_13+FS_PREMIXUP15_PU25+FS_TTbar_13_PRMXLOCALUP15_PU25+HARVESTUP15FS

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2891565
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2891373
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 2, 2018

+upgrade

@fabiocos
Copy link
Contributor

fabiocos commented Aug 6, 2018

@fabozzi @prebello could you please have a look and sign it in case?

@prebello
Copy link
Contributor

prebello commented Aug 6, 2018

+1

acc tests approved.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Aug 6, 2018

+1

@cmsbuild cmsbuild merged commit 4bdb552 into cms-sw:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants