DD Core Cleanup #24153
DD Core Cleanup #24153
Conversation
ianna
commented
Aug 1, 2018
ianna
commented
- Move access to Singleton instances to a base class
- Remove unsafe member functions from a base class
- Use C++11 type aliases
- Use CMS coding style
- Remove commented out code
- Move tests and their helper functions from a Core to a Regression test package
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24153/5845 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/Core @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Tested at: b60e21b You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Package Geometry/DTGeometryBuilder built
>> Entering Package DetectorDescription/RegressionTest
Entering library rule at src/DetectorDescription/RegressionTest/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-07-31-2300/src/DetectorDescription/RegressionTest/plugins/CompareDDCompactViews.cc
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-07-31-2300/src/DetectorDescription/RegressionTest/plugins/CompareDDCompactViews.cc:8:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-07-31-2300/poison/DetectorDescription/Core/src/DDCheck.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
#error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
^~~~~
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-07-31-2300/src/DetectorDescription/RegressionTest/plugins/CompareDDCompactViews.cc: In member function 'virtual void CompareDDCompactViews::beginRun(const edm::Run&, const edm::EventSetup&)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-07-31-2300/src/DetectorDescription/RegressionTest/plugins/CompareDDCompactViews.cc:42:3: error: 'DDCheckMaterials' was not declared in this scope
DDCheckMaterials( std::cout );
|
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
cmsbuild
added
code-checks-pending
comparison-pending
and removed
code-checks-approved
comparison-notrun
tests-rejected
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24153/5850 |
|
Pull request #24153 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
| return prep_ ? bool( prep_->second ) | ||
| : false; | ||
| } | ||
| void create( const N& name, C vals ) { |
There was a problem hiding this comment.
Should we consider eventually changing the create method to be taking a std::unique_ptr<C> since it appears to take ownership of the value?
There was a problem hiding this comment.
indeed, my thoughts exactly :-)
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
