Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake CPE #24175

Merged
merged 15 commits into from Aug 11, 2018
Merged

Fake CPE #24175

merged 15 commits into from Aug 11, 2018

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Aug 2, 2018

In this PR I introduce a CPE that just returns position and error previously stored in a "map".
Typical values would be those of the SimHit.
An example of a filler from SimHits is also provided.

The main technical limitation is that it does not support multi-threading.
Given that its main use is to check tracking mostly with particle gun this is not a big issue.

tested as

10808.0_SingleMuPt100+SingleMuPt100_pythia8_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018]$ cmsRun $CMSSW_BASE/src/RecoTracker/TrackProducer/test/RefitWithSim.py 

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2018

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24175/5866

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24175/5866/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24175/5866/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2018

@VinInn
Copy link
Contributor Author

VinInn commented Aug 2, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #24175 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@VinInn
Copy link
Contributor Author

VinInn commented Aug 11, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29779/console Started: 2018/08/11 10:07

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24175/29779/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2891469
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2891278
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@slava77
Copy link
Contributor

slava77 commented Aug 11, 2018

+1

for #24175 91c39e9

  • code changes are in line with the PR description and the follow up review. Standard workflows are not affected, the added functionality is useful for analysis/private tests.
  • jenkins tests pass and comparisons with the baseline show no differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ed178ed into cms-sw:master Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants