Fix cross product for gcc 8 #24205
Fix cross product for gcc 8 #24205
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24205/5895 |
|
A new Pull Request was created by @VinInn (Vincenzo Innocente) for master. It involves the following packages: DataFormats/Math @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
| mathSSE::Vec4<double> yAxis(-0.0144846,0.932024,-0.362108); | ||
| mathSSE::Vec4<double> zAxis(-0.204951,0.351689,0.913406); | ||
|
|
||
| auto xAxis = ::cross(yAxis,zAxis); |
There was a problem hiding this comment.
This line is failing to compile in the RelVals
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_aarch64_gcc700/CMSSW_10_3_X_2018-08-08-2300/DataFormats/Math
|
@Dr15Jones @VinInn this is an aarch64 build specific problem as far as I can see |
gcc 8 decided for undefined (weird) behavior when -0.0 is involved in case of fast-math
move to integer (assembler identical!)
see issue #24203
will force compilation of the universe...