-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx150 Add a new validation code for Digi's to be used in standalone way #24494
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24494/6351 |
A new Pull Request was created by @bsunanda for master. It involves the following packages: Validation/HGCalValidation @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
please test |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda this code looks so far standalone, please correct me in case. Where was it really tested, and where it should be used? |
@fabiocos This is done in a private test with simulated DIGI collection. The person (Koushik) who does HGCal validation for SIM/DIGI/RECHit uses standalone tools outside normal RelVal runs. The normal RelVal uses DQM tools and for private tests it is easy to produce a ROOT file which can be seen by a bare ROOT browser. |
@bsunanda my question is: is this code exercised in any regular workflow? I would say no... |
@fabiocos No I did not use in in regular workflow. But I used outputs from WF 24034.0 to test it |
+1 |
No description provided.