-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from tinyxml to tinyxml2 in FWCore-MessageLogger #24503
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24503/6365 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: FWCore/MessageLogger @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
branch.SetAttribute("Name", iBranch.first); | ||
branch.SetAttribute("ReadCount", iBranch.second); | ||
ost << branch << "\n"; | ||
tinyxml2::XMLPrinter printer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
tinyxml2::XMLElement * branch = doc.NewElement("Branch"); | ||
branch->SetAttribute("Name", iBranch.first.c_str()); | ||
branch->SetAttribute("ReadCount", int64_t(iBranch.second)); | ||
branch->Accept(&printer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
{ | ||
std::lock_guard<std::mutex> lock(write_mutex); | ||
msg << fallback << "\n"; | ||
fallback->Accept(&printer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indention
tinyxml2::XMLElement * branch = doc.NewElement("Branch"); | ||
branch->SetAttribute("Name", iBranch.first.c_str()); | ||
branch->SetAttribute("ReadCount", int64_t(iBranch.second)); | ||
branch->Accept(&printer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
branch.SetAttribute("Name", iBranch.first); | ||
branch.SetAttribute("ReadCount", iBranch.second.value().load()); | ||
ost << branch << "\n"; | ||
tinyxml2::XMLPrinter printer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
tinyxml2::XMLElement * branch = doc.NewElement("Branch"); | ||
branch->SetAttribute("Name", iBranch.first.c_str()); | ||
branch->SetAttribute("ReadCount", int64_t(iBranch.second.value().load())); | ||
branch->Accept(&printer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
branch.SetAttribute("Name", iBranch.first); | ||
branch.SetAttribute("ReadCount", iBranch.second); | ||
ost << branch << "\n"; | ||
tinyxml2::XMLPrinter printer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
{ | ||
std::lock_guard<std::mutex> lock(write_mutex); | ||
msg << skipped << "\n"; | ||
skipped->Accept(&printer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep consistent indentation
@@ -725,7 +742,7 @@ namespace edm { | |||
JobReport::dumpFiles(void) { | |||
std::ostringstream msg; | |||
|
|||
|
|||
tinyxml2::XMLDocument doc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will having the doc
outside of the loop mean it will accumulate memory until the loop finishes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit is using a method to delete the document nodes when the doc is used to create new text objects inside loops.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24503/6370 |
Pull request #24503 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
-1 You can see the log for git cms-merge-topic here: |
please test I would suggest to merge this PR and then #24810 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Recently we added tinyxml2 external and now we are moving pkgs that were using tinyxml to tinyxml2.