Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Class Versions of classes impacted by ROOT 6 #2460

Merged
merged 1 commit into from
Feb 13, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 13, 2014

This pull request fixes most (perhaps all) ROOT6 relval errors of the form:

The StreamerInfo of class MyClass read from file MyFIle.root has the same version (=10) as the active class but a different checksum.

The classes in question have different checksums in ROOT 5 and ROOT 6 for valid reasons.
This pull request updates the version numbers for these classes. Because edmClassVersion is currently disabled in ROOT6, it is non-trivial to get the checksums for ROOT6 and guarantee that they are correct.. Therefore, "999999999" is used as a placeholder for the checksum in the ROOT6 version. When edmCheckClassVersion is turned back on, each instance of "999999999" can then be easily changed to the correct checksum.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

Update Class Versions of classes impacted by ROOT 6

It involves the following packages:

DataFormats/BeamSpot
DataFormats/Candidate
DataFormats/GsfTrackReco
DataFormats/JetReco
DataFormats/MuonReco
DataFormats/TrackReco

@nclopezo, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request Feb 13, 2014
ROOT6 -- Update Class Versions of classes impacted by ROOT 6
@ktf ktf merged commit 395fbd0 into cms-sw:CMSSW_7_1_ROOT6_X Feb 13, 2014
@wmtan wmtan deleted the UpdateClassVersionsForROOT6 branch February 16, 2014 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants