Add a flag to prevent storage of LHEXMLStringProduct, update the dump…

[efeyazgan]

backport of #22935

[cmsbuild]

A new Pull Request was created by @efeyazgan (Efe Yazgan) for CMSSW_9_4_X.

It involves the following packages:

GeneratorInterface/LHEInterface

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Add a flag to prevent storage of LHEXMLStringProduct #22935

[efeyazgan]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30584/console Started: 2018/09/24 18:01

[cmsbuild]

-1

Tested at: 2fbbc71

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24632/30584/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Mon Sep 24 19:34:04 2018-date Mon Sep 24 19:28:27 2018 s - exit: 35584

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24632/30584/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 104
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721227
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[qliphy]

This seems to be a random error? Also appeared here #24585 and seems to disappear after a 2nd try...

[qliphy]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30598/console Started: 2018/09/25 03:54

[cmsbuild]

+1
Tested at: 2fbbc71
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24632/30598/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24632/30598/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 103
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721228
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[efeyazgan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@efeyazgan @prebello @pgunnell @qliphy the backport should be ok, as the content of the data structure is not modified, just an empty object if filled instead of the large blob of text

[fabiocos]

+1