Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database format resolved centrally in connection pool #2472

Merged
merged 2 commits into from
Feb 17, 2014

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Feb 14, 2014

Fix aiming performance improvement in the loading of condition.
The resolution of the database format ( in case of existing tables in the target DB) is done centrally at the first connection. For a given connection string, the db technology is stored and re-used for further connections.

PAckages involved:
CondCore/CondDB
CondCore/DBCommon
CondCore/DBOutputService
CondCore/ORA
CondCore/Utilities

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_7_1_X.

Database format resolved centrally in connection pool

It involves the following packages:

CondCore/CondDB
CondCore/DBCommon
CondCore/DBOutputService
CondCore/ORA
CondCore/Utilities

@apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@apfeiffer1
Copy link
Contributor

+1
assuming Jenkins agrees ...

Thanks, have a nice w/e !

   cheers, andreas

@diguida
Copy link
Contributor

diguida commented Feb 14, 2014

+1
provided Jenkins agrees.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
I ran the usual tests and I found errors in the following unit tests:

---> test testDbSession had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2472/189/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

Pull request #2472 was updated. @apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

@apfeiffer1
Copy link
Contributor

+1

1 similar comment
@diguida
Copy link
Contributor

diguida commented Feb 17, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 17, 2014
DB -- Database format resolved centrally in connection pool
@ktf ktf merged commit ab76e8b into cms-sw:CMSSW_7_1_X Feb 17, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
adds py2-cycler as external for matplotlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants