Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update several heavy ion wfs to 2018 pp_on_AA era #24773

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

mandrenguyen
Copy link
Contributor

Certain heavy ion MC workflows were still using previous runs and/or eras.
The PR updates them to the 2018 "pp_on_AA" era that will be used this year.
Wfs 150.1, 150.2 and 150.3 become 158.1,158.2 and 158.3.
These are pp events reconstructed with the heavy-ion era.
They were previously still running the 2015 setup.

300, 301 and 302 are heavy-ion embedded workflows, i.e., embedding pythia events into Hydjet MB.
They keep the same workflow numbers but are updated from the old "HeavyIons" scenario to the new era.

@BetterWang

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2018

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30830/console Started: 2018/10/01 22:45

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24773/30830/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 795 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162800
  • DQMHistoTests: Total failures: 8928
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153675
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Oct 5, 2018

please test workflow 300,301,302,158.1,158.2,158.3

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30897/console Started: 2018/10/05 11:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24773/30897/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24773/158.1_QCD_Pt_80_120_13_HI+QCD_Pt_80_120_13_HI+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24773/158.2_PhotonJets_Pt_10_13_HI+PhotonJets_Pt_10_13_HI+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24773/158.3_ZEEMM_13_HI+ZEEMM_13_HI+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24773/300.0_Pyquen_GammaJet_pt20_2760GeV+Pyquen_GammaJet_pt20_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24773/301.0_Pyquen_DiJet_pt80to120_2760GeV+Pyquen_DiJet_pt80to120_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 594 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162979
  • DQMHistoTests: Total failures: 8512
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3154270
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Oct 7, 2018

@prebello @pgunnell @zhenhu could you please check and sign it in case?

@zhenhu
Copy link
Contributor

zhenhu commented Oct 8, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Oct 8, 2018

@kpedro88 is this ok for you?

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 8, 2018

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Oct 9, 2018

+1

@cmsbuild cmsbuild merged commit 7543bd3 into cms-sw:master Oct 9, 2018
@mandrenguyen mandrenguyen deleted the hiRelVal2018MC_ppReco branch October 8, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants