Don't register default values of untracked parameter sets #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I took CMSSW_7_0_X_2013-08-07-0200, pulled these changes, and ran the RelVals and unit tests, all tests passed. |
|
The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core @cms-git-visualization, @cms-git-core, @cms-git-geometry |
ktf
added a commit
that referenced
this pull request
Aug 7, 2013
…eters Don't register default values of untracked parameter sets
parbol
pushed a commit
to parbol/cmssw
that referenced
this pull request
Mar 5, 2015
Susy tau update
makortel
pushed a commit
to makortel/cmssw
that referenced
this pull request
Apr 22, 2015
IB Pages: show when the IB is a full build or a patch IB
cmsbuild
pushed a commit
that referenced
this pull request
Dec 11, 2023
* Update BuildFile.xml to add conifer * Delete L1Trigger/TrackTrigger/interface/conifer.h
zhenbinwu
pushed a commit
to zhenbinwu/cmssw
that referenced
this pull request
Feb 14, 2024
* Update BuildFile.xml to add conifer * Delete L1Trigger/TrackTrigger/interface/conifer.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function ParameterSet::getUntrackedParameterSet registers the passed in default value argument. This is not thread safe, and is totally unnecesary, This pull request removes the registration. This is a step toward the multithreaded framework.