Phase2-hgx158 Correct density of PCB for v9 geometry #24807

bsunanda · 2018-10-04T18:23:34Z

A new material with density 1.85 g/cc and composition same a M_NEMA FR4 plate is defined and used for v9 HGCal geometry

cmsbuild · 2018-10-04T18:23:54Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-10-04T18:26:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24807/6754

cmsbuild · 2018-10-04T18:26:30Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2018-10-04T18:29:53Z

@cmsbuild Please test

cmsbuild · 2018-10-04T18:30:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30892/console Started: 2018/10/04 20:30

cmsbuild · 2018-10-04T19:58:50Z

+1
Tested at: aea5497
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24807/30892/summary.html

cmsbuild · 2018-10-04T19:58:53Z

Comparison job queued.

cmsbuild · 2018-10-04T21:13:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24807/30892/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162909
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3162710
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

ianna · 2018-10-08T08:20:37Z

Geometry/HGCalCommonData/data/hgcal/v9/hgcal.xml

@@ -87,6 +87,23 @@
      <rMaterial name="materials:Copper"/>
    </MaterialFraction>
  </CompositeMaterial>
+  <CompositeMaterial name="HGC_G10-FR4" density="1.85*g/cm3" symbol=" " method="mixture by weight">


@bsunanda - It looks like maintaining a separate hgcalMaterials.xml file would be easier.

@ianna I thought about that. Should I then change all scenario's with HGCal?

yes, please.

cmsbuild · 2018-10-08T14:38:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24807/6775

cmsbuild · 2018-10-08T14:38:24Z

Pull request #24807 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

bsunanda · 2018-10-08T14:39:03Z

@cmsbuild Please test

cmsbuild · 2018-10-08T14:39:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30926/console Started: 2018/10/08 16:39

cmsbuild · 2018-10-08T16:54:05Z

+1
Tested at: e581c7a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24807/30926/summary.html

cmsbuild · 2018-10-08T16:54:08Z

Comparison job queued.

cmsbuild · 2018-10-08T18:33:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24807/30926/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162979
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3162781
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

kpedro88 · 2018-10-08T19:16:44Z

+upgrade

ianna · 2018-10-09T05:40:17Z

+1

cmsbuild · 2018-10-09T05:40:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-10-11T08:29:22Z

+1

Sunanda added 2 commits October 4, 2018 20:17

Correct density of PCB for v9 geometry

ad1d7d7

Change density to 1.85 g/cc

aea5497

cmsbuild added this to the CMSSW_10_3_X milestone Oct 4, 2018

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Oct 4, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 4, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 4, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 4, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 4, 2018

ianna suggested changes Oct 8, 2018

View reviewed changes

Make a separate xml file for HGCal

e581c7a

cmsbuild removed code-checks-approved comparison-available labels Oct 8, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 8, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 8, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 8, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 8, 2018

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 8, 2018

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Oct 9, 2018

smuzaffar modified the milestones: CMSSW_10_3_X, CMSSW_10_4_X Oct 10, 2018

cmsbuild added orp-approved and removed orp-pending labels Oct 11, 2018

cmsbuild merged commit 683ebc5 into cms-sw:master Oct 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx158 Correct density of PCB for v9 geometry #24807

Phase2-hgx158 Correct density of PCB for v9 geometry #24807

bsunanda commented Oct 4, 2018

cmsbuild commented Oct 4, 2018

cmsbuild commented Oct 4, 2018

cmsbuild commented Oct 4, 2018

bsunanda commented Oct 4, 2018

cmsbuild commented Oct 4, 2018 •

edited

Loading

cmsbuild commented Oct 4, 2018

cmsbuild commented Oct 4, 2018

cmsbuild commented Oct 4, 2018

ianna Oct 8, 2018

bsunanda Oct 8, 2018

ianna Oct 8, 2018

cmsbuild commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

bsunanda commented Oct 8, 2018

cmsbuild commented Oct 8, 2018 •

edited

Loading

cmsbuild commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

kpedro88 commented Oct 8, 2018

ianna commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

fabiocos commented Oct 11, 2018

Phase2-hgx158 Correct density of PCB for v9 geometry #24807

Phase2-hgx158 Correct density of PCB for v9 geometry #24807

Conversation

bsunanda commented Oct 4, 2018

cmsbuild commented Oct 4, 2018

cmsbuild commented Oct 4, 2018

cmsbuild commented Oct 4, 2018

bsunanda commented Oct 4, 2018

cmsbuild commented Oct 4, 2018 • edited Loading

cmsbuild commented Oct 4, 2018

cmsbuild commented Oct 4, 2018

cmsbuild commented Oct 4, 2018

ianna Oct 8, 2018

Choose a reason for hiding this comment

bsunanda Oct 8, 2018

Choose a reason for hiding this comment

ianna Oct 8, 2018

Choose a reason for hiding this comment

cmsbuild commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

bsunanda commented Oct 8, 2018

cmsbuild commented Oct 8, 2018 • edited Loading

cmsbuild commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

kpedro88 commented Oct 8, 2018

ianna commented Oct 9, 2018

cmsbuild commented Oct 9, 2018

fabiocos commented Oct 11, 2018

cmsbuild commented Oct 4, 2018 •

edited

Loading

cmsbuild commented Oct 8, 2018 •

edited

Loading