Phase2-hgx162 Add the possibility of navigation in HGCalTopology #24897

bsunanda · 2018-10-16T14:38:50Z

This only allows the possibility in a plane

kpedro88 · 2018-10-16T14:48:15Z

Geometry/HGCalCommonData/src/HGCalDDDConstants.cc

+  //     =11..16: the corners clockwise from bottom
+  int N = (type == 0) ? hgpar_->nCellsFine_ : hgpar_->nCellsCoarse_;
+  if (cellU == 0) {
+    if      (cellV == 0)         return 12;


It would be clearer to make these cell type numbers into named constants (or an enum class) so we can tell what they mean at a glance

Thought about it. Will do that

bsunanda · 2018-10-16T18:17:00Z

@cmsbuild Please test

bsunanda · 2018-10-16T18:18:02Z

@fbaiocos @smuzaffar This PR is in a funny shape - could you please let me know how to rescue this

cmsbuild · 2018-10-16T18:18:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-10-16T18:20:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24897/6868

cmsbuild · 2018-10-16T18:22:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31094/console Started: 2018/10/16 21:13

cmsbuild · 2018-10-16T18:22:37Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CaloTopology
Geometry/HGCalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2018-10-16T18:23:00Z

@bsunanda it looks like the bot woke up

cmsbuild · 2018-10-16T21:56:14Z

+1
Tested at: ad2218d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24897/31094/summary.html

cmsbuild · 2018-10-16T21:56:17Z

Comparison job queued.

cmsbuild · 2018-10-16T22:57:56Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24897/31094/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2994843
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2994645
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

kpedro88 · 2018-10-17T14:16:24Z

+upgrade

bsunanda · 2018-10-24T10:52:01Z

@ianna @kpedro88 Please sign this PR

kpedro88 · 2018-10-24T10:55:08Z

+upgrade

ianna · 2018-10-24T12:29:31Z

+1

cmsbuild · 2018-10-24T12:29:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-10-24T15:39:03Z

please test

cmsbuild · 2018-10-24T15:39:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31254/console Started: 2018/10/24 17:41

bsunanda · 2018-10-24T16:22:19Z

@fabiocos I am wondering why you restarted the testing

cmsbuild · 2018-10-24T18:11:07Z

+1
Tested at: 17526aa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24897/31254/summary.html

cmsbuild · 2018-10-24T18:11:10Z

Comparison job queued.

cmsbuild · 2018-10-24T19:41:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24897/31254/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 258 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2994843
DQMHistoTests: Total failures: 311
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2994335
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2018-10-25T10:33:01Z

+1

differences are concentrated in upgrade workflows

Add the possibility of navigation in HGCalTopology

9bac3e7

kpedro88 reviewed Oct 16, 2018

View reviewed changes

Changed to enum

ad2218d

cmsbuild added this to the CMSSW_10_4_X milestone Oct 16, 2018

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Oct 16, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 16, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 16, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 16, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 16, 2018

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 24, 2018

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Oct 24, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Oct 24, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 24, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 24, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 24, 2018

cmsbuild added orp-approved and removed orp-pending labels Oct 25, 2018

cmsbuild merged commit f1ea278 into cms-sw:master Oct 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx162 Add the possibility of navigation in HGCalTopology #24897

Phase2-hgx162 Add the possibility of navigation in HGCalTopology #24897

bsunanda commented Oct 16, 2018

kpedro88 Oct 16, 2018

bsunanda Oct 16, 2018

bsunanda commented Oct 16, 2018

bsunanda commented Oct 16, 2018

cmsbuild commented Oct 16, 2018

cmsbuild commented Oct 16, 2018

cmsbuild commented Oct 16, 2018 •

edited

Loading

cmsbuild commented Oct 16, 2018

kpedro88 commented Oct 16, 2018

cmsbuild commented Oct 16, 2018

cmsbuild commented Oct 16, 2018

cmsbuild commented Oct 16, 2018

kpedro88 commented Oct 17, 2018

bsunanda commented Oct 24, 2018

kpedro88 commented Oct 24, 2018

ianna commented Oct 24, 2018

cmsbuild commented Oct 24, 2018

fabiocos commented Oct 24, 2018

cmsbuild commented Oct 24, 2018 •

edited

Loading

bsunanda commented Oct 24, 2018

cmsbuild commented Oct 24, 2018

cmsbuild commented Oct 24, 2018

cmsbuild commented Oct 24, 2018

fabiocos commented Oct 25, 2018

Phase2-hgx162 Add the possibility of navigation in HGCalTopology #24897

Phase2-hgx162 Add the possibility of navigation in HGCalTopology #24897

Conversation

bsunanda commented Oct 16, 2018

kpedro88 Oct 16, 2018

Choose a reason for hiding this comment

bsunanda Oct 16, 2018

Choose a reason for hiding this comment

bsunanda commented Oct 16, 2018

bsunanda commented Oct 16, 2018

cmsbuild commented Oct 16, 2018

cmsbuild commented Oct 16, 2018

cmsbuild commented Oct 16, 2018 • edited Loading

cmsbuild commented Oct 16, 2018

kpedro88 commented Oct 16, 2018

cmsbuild commented Oct 16, 2018

cmsbuild commented Oct 16, 2018

cmsbuild commented Oct 16, 2018

kpedro88 commented Oct 17, 2018

bsunanda commented Oct 24, 2018

kpedro88 commented Oct 24, 2018

ianna commented Oct 24, 2018

cmsbuild commented Oct 24, 2018

fabiocos commented Oct 24, 2018

cmsbuild commented Oct 24, 2018 • edited Loading

bsunanda commented Oct 24, 2018

cmsbuild commented Oct 24, 2018

cmsbuild commented Oct 24, 2018

cmsbuild commented Oct 24, 2018

fabiocos commented Oct 25, 2018

cmsbuild commented Oct 16, 2018 •

edited

Loading

cmsbuild commented Oct 24, 2018 •

edited

Loading