Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cscTriggerPrimitiveDigis to prevent online client from crashing. #24905

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Remove cscTriggerPrimitiveDigis to prevent online client from crashing. #24905

merged 1 commit into from
Oct 23, 2018

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Oct 17, 2018

Needs to be back-ported to 10_3 for HI running.
@threus @ptcox @barvic

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DQM/Integration

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

Hi @dildick, I can't seem to fins you in the DQM contacts list. Could you please introduce yourself shortly?

@barvic
Copy link
Contributor

barvic commented Oct 17, 2018

Hi @andrius-k, just in case, Sven works with CSC and currently handling parts of our outdated CSC trigger-related code.

@ptcox
Copy link
Contributor

ptcox commented Oct 17, 2018 via email

@andrius-k
Copy link

please test

Thanks for clarification!

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31123/console Started: 2018/10/18 09:42

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24905/31123/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994645
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@jfernan2 @andrius-k is there any issue with this PR, or could we move it forward?

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4312fe0 into cms-sw:master Oct 23, 2018
@dildick dildick deleted the patch-3 branch March 22, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants