-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cscTriggerPrimitiveDigis to prevent online client from crashing. #24905
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24905/6874 |
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: DQM/Integration @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Hi @dildick, I can't seem to fins you in the DQM contacts list. Could you please introduce yourself shortly? |
Hi @andrius-k, just in case, Sven works with CSC and currently handling parts of our outdated CSC trigger-related code. |
Sven is not a DQM developer, per se - he's a CSC trigger primitive
expert. His clean up of superseded trigger primitive code accidentally
missed this online DQM config file. He's submitting the pull request to
correct it as a favour to the rest of us.
Regards, Tim (CSC DPG)
Andrius wrote on 18/10/17 15:46 :
…
Hi @dildick <https://github.com/dildick>, I can't seem to fins you in
the DQM contacts list
<https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts>. Could you
please introduce yourself shortly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24905 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE2Fnv383t6MGDfJL6cEnwFablF2UeQcks5ulzSwgaJpZM4Xj4Va>.
|
please test Thanks for clarification! |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@jfernan2 @andrius-k is there any issue with this PR, or could we move it forward? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Needs to be back-ported to 10_3 for HI running.
@threus @ptcox @barvic