-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update L1 menu in HLT relval and Prompt Like GTs #25068
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25068/7062 |
A new Pull Request was created by @tocheng (Tongguang) for master. It involves the following packages: Configuration/AlCa @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Sorry, but this does not look correct to me: You replaced the 2018 pp L1T menu L1Menu_Collisions2018_v2_1_0-d1_xml by the L1T HIon menu, Could you please elaborate? ?? |
Hello @Martin-Grunewald , I see in PR #25030 , So I updated the GTs in the autoCond for 'run2_hlt_relval' and 'run2_data_promptlike' in the PR. |
Yes, that was my kludge to get it to work for the internal TSG tests (these GTs are NOT used outside TSG), but as expressed in the e-mail thread, it is not really correct - see especially the last paragraph quoted below!
|
maybe make a clone of run2_hlt_relval and run2_data_promptlike, call them run2_hlt_relval _hi and run2_data_promptlike_hi, with the only difference so far the L1T menu??? ?? |
@Martin-Grunewald |
Yes, sure, I would follow your lead to have it corrected in our TSG setup. |
Yes I will. Sorry for the confusion. |
@cmsbuild please abort |
Jenkins tests are aborted. |
…_relval and prompt-like GTs, update the HI L1 menu for HI 2018 upgrade realistic GT
@Martin-Grunewald |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25068/7063 |
Looks good to me, thanks! |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
If I move the 2018 HI HLT menu to HIon in relval_steps, I see that both wf 300.0 and 158.0 complete successfully and finds the L1 menu. A number of warnings need to be checked, but the basic functionality looks to be there. As soon as this PR is ready I will update the relval_steps @prebello @zhenhu |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@tocheng unless you have further updates, I think we could consider this PR to be merged and move forward with the remaining updates |
Hello @fabiocos , I don't have further updates. |
+1 |
The PR is to update GTs according to the L1 menu change in HLT relval and prompt like autoConds in PR #25029 and #25030.
Two keys, run2_hlt_relval_hi and run2_data_promptlike_hi are added for HLT relval and test reco GTs for heavy Ion data taking.
The update in HLT relval GT can be seen at
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_dataRun2_HLT_relval_HI_v1/103X_dataRun2_HLT_relval_v4
Besides L1 menu, the differences are CTPPS local reconstruction, GEM emap and geometry, JEC, HBHE negative energy filter and using HLT-synchronized track MVA selector.
The update in Prompt like GT can be seen at
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_dataRun2_PromptLike_HI_v1/103X_dataRun2_PromptLike_v6
Besides L1 menu, the main updates includes GEM emap and RPC CPPF link.
The updated in MC (upgrade2018_realistic) can be seen at
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_upgrade2018_realistic_HI_v9/103X_upgrade2018_realistic_HI_v8
The PR doesn't update the HLT relval and Prompt-like GT.