-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced remaining BOOST_FOREACH #25132
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25132/7128 |
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: CalibTracker/SiStripCommon @andrius-k, @schneiml, @nsmith-, @rekovic, @thomreis, @pohsun, @peruzzim, @perrotta, @civanch, @zhenhu, @cmsbuild, @fwyzard, @mdhildreth, @jfernan2, @tocheng, @slava77, @Martin-Grunewald, @prebello, @kmaeshima, @monttj, @pgunnell, @franzoni, @fgolf, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 for #25132 afc8e49
|
+1 |
+1 |
+1 |
+1 |
+1 |
+1 @fabiocos I was waiting for the end of changes in this PR. Thank you to inform. |
+1 DQM differences look unrelated to this PR. I will fix separately the CMSSW code rule violations, that are not caused explicitly by changes in this PR. |
Analysis pending :D |
merge |
Just a simple PR with more or less automatic replacements of the obsolete BOOST_FOREACH with range based loops. It's a follow up on #24789 and removes all the remaining incidents of BOOST_FOREACH.