Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced remaining BOOST_FOREACH #25132

Merged
merged 10 commits into from
Nov 19, 2018
Merged

Replaced remaining BOOST_FOREACH #25132

merged 10 commits into from
Nov 19, 2018

Conversation

guitargeek
Copy link
Contributor

Just a simple PR with more or less automatic replacements of the obsolete BOOST_FOREACH with range based loops. It's a follow up on #24789 and removes all the remaining incidents of BOOST_FOREACH.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CalibTracker/SiStripCommon
CalibTracker/SiStripDCS
CalibTracker/SiStripLorentzAngle
DPGAnalysis/Skims
DQM/HcalCommon
DQM/L1TMonitor
DQMOffline/JetMET
DQMOffline/Lumi
EventFilter/CSCRawToDigi
EventFilter/L1TRawToDigi
HLTrigger/HLTanalyzers
HLTrigger/HLTcore
HLTrigger/HLTfilters
HLTrigger/special
HLTriggerOffline/Egamma
HeavyFlavorAnalysis/Onia2MuMu
L1Trigger/CSCTrackFinder
L1TriggerConfig/RPCTriggerConfig
MuonAnalysis/MomentumScaleCalibration
MuonAnalysis/MuonAssociators
RecoJets/JetProducers
RecoLocalTracker/SiStripClusterizer
RecoLuminosity/LumiProducer
RecoMuon/MuonIdentification
RecoTauTag/ImpactParameter
RecoTauTag/TauTagTools
RecoTracker/ConversionSeedGenerators
SimDataFormats/TrackerDigiSimLink
SimTracker/TrackAssociation

@andrius-k, @schneiml, @nsmith-, @rekovic, @thomreis, @pohsun, @peruzzim, @perrotta, @civanch, @zhenhu, @cmsbuild, @fwyzard, @mdhildreth, @jfernan2, @tocheng, @slava77, @Martin-Grunewald, @prebello, @kmaeshima, @monttj, @pgunnell, @franzoni, @fgolf, @lpernie can you please review it and eventually sign? Thanks.
@echabert, @TaiSakuma, @yslai, @felicepantaleo, @forthommel, @yduhm, @rappoccio, @argiro, @Martin-Grunewald, @alesaggio, @thomreis, @ahinzmann, @threus, @mmusich, @seemasharmafnal, @mmarionncern, @battibass, @makortel, @jhgoh, @jdolen, @HuguesBrun, @drkovalskyi, @ptcox, @pieterdavid, @rociovilar, @abbiendi, @barvic, @DryRun, @GiacomoSguazzoni, @tocheng, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @rovere, @deguio, @schoef, @mschrode, @ebrondol, @mtosi, @dgulhan, @clelange, @echapon, @trocino, @gbenelli, @calderona, @mverzett, @folguera, @gpetruc, @mariadalfonso, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

thomreis commented Nov 6, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31490/console Started: 2018/11/06 15:13

@slava77
Copy link
Contributor

slava77 commented Nov 14, 2018

+1

for #25132 afc8e49

  • technical code changes are in line with the PR description and the follow up review
  • jenkins tests pass and comparisons with the baseline show no relevant differences

@pohsun
Copy link

pohsun commented Nov 14, 2018

+1

@thomreis
Copy link
Contributor

thomreis commented Nov 14, 2018

+1

@andrius-k
Copy link

+1

@civanch
Copy link
Contributor

civanch commented Nov 18, 2018

+1

@Martin-Grunewald
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@prebello @zhenhu could you please check and sign? The changes under your supervision (DPGAnalysis/Skims) look quite straightforward to me

@prebello
Copy link
Contributor

+1

@fabiocos I was waiting for the end of changes in this PR. Thank you to inform.

@fabiocos
Copy link
Contributor

+1

DQM differences look unrelated to this PR. I will fix separately the CMSSW code rule violations, that are not caused explicitly by changes in this PR.

@guitargeek
Copy link
Contributor Author

Analysis pending :D

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ac309eb into cms-sw:master Nov 19, 2018
@guitargeek guitargeek deleted the BOOST_FOREACH branch November 21, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.