update HGCal dEdX weights consistently

[kpedro88]

The dEdX weight vector for HGCal calibrated RecHits is wrapped in a PSet so it can be modified by modifiers and imported consistently into configurations for other modules.

attn: @rovere @nsmith-

[kpedro88]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25208/7214

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31604/console Started: 2018/11/12 15:45

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

RecoEgamma/EgammaTools
RecoLocalCalo/HGCalRecProducers

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @Sam-Harper, @sethzenz, @felicepantaleo, @jainshilpi, @rovere, @lgray, @cseez, @pfs, @varuns23 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 9be5bf9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25208/31604/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25208/31604/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013827
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013629
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

+upgrade

[kpedro88]

please test
(to pick up the new D35 workflow)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31676/console Started: 2018/11/15 18:46

[perrotta]

@kpedro88 : do I understand correctly that this PR fixes a bug because previously the dedx weights were not imported consistently in the other modules when modified? (And we should see it while testing D35, as you asked right now)

[kpedro88]

@perrotta yes

[cmsbuild]

+1
Tested at: 9be5bf9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25208/31676/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25208/31676/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1073 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 58
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013056
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• Bug fix for the Phase 2 scenarios which include HGCal V9: now dedx weights are correctly propagated to all modules which need them
• Scenarios with the affected Phase 2 scenarios (e.g. TTbar14TeV2023D35 wf27434 in the automatic jenkins tests) are modified accordingly
• All other workflows stay untouched

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1