-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change order of end and produce for Run and Lumi for one modules #25237
Conversation
The cache was being cleared before the call to produce during the end transitions of Run and LuminosityBlocks for one::EDProducer. Reversing the order of the callbacks fixes the problem and makes the call order the same as is done for global::EDProducers.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25237/7257 |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
+1 DQM changes look unrelated to this PR |
@Dr15Jones the addition of this PR on top of CMSSW_10_4_X_2018-11-14-2300 causes a reproducible |
The cache was being cleared before the call to produce during the end transitions of Run and LuminosityBlocks for one::EDProducer. Reversing the order of the callbacks fixes the problem and makes the call order the same as is done for global::EDProducers.