Fix two memory leaks in pixel and strip digitizers

[makortel]

A valgrind log from @Dr15Jones pointed to a memory leak in pixel and strip digitizers. The function StorePileupInformation() is called from MixingModule::doPileup() once per (signal) event.

The minimal fix is to use std::unique_ptr.

Tested in 10_4_0_pre2, no changes expected.

@mdhildreth @Dr15Jones

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25294/7314

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

SimTracker/SiPixelDigitizer
SimTracker/SiStripDigitizer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @GiacomoSguazzoni, @rovere, @VinInn, @prolay, @dkotlins, @ebrondol, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31744/console Started: 2018/11/19 23:27

[cmsbuild]

-1

Tested at: 5805425

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25294/31744/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found compilation error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-11-19-1100/src/SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-11-19-1100/src/SimTracker/SiPixelDigitizer/plugins/PreMixingSiPixelWorker.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-11-19-1100/src/SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizerAlgorithm.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-11-19-1100/src/SimTracker/SiPixelDigitizer/plugins/SealModule.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-11-19-1100/src/SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizer.cc: In member function 'virtual void cms::SiPixelDigitizer::finalizeEvent(edm::Event&, const edm::EventSetup&)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-11-19-1100/src/SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizer.cc:254:38: error: no match for 'operator=' (operand types are 'std::unique_ptr' and 'PileupMixingContent*')
     PileupInfo_ = getEventPileupInfo();
                                      ^
In file included from /cvmfs/cms-ib.cern.ch/nweek-02551/slc6_amd64_gcc700/external/gcc/7.0.0-omkpbe2/include/c++/7.3.1/memory:80:0,
                 from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_4_X_2018-11-19-1100/src/SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizer.cc:22:
/cvmfs/cms-ib.cern.ch/nweek-02551/slc6_amd64_gcc700/external/gcc/7.0.0-omkpbe2/include/c++/7.3.1/bits/unique_ptr.h:281:7: note: candidate: std::unique_ptr<_Tp, _Dp>& std::unique_ptr<_Tp, _Dp>::operator=(std::unique_ptr<_Tp, _Dp>&&) [with _Tp = PileupMixingContent; _Dp = std::default_delete]


• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[makortel]

Ok, so I forgot to compile myself... Closing while doing that.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25294/7331

[cmsbuild]

Pull request #25294 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[makortel]

@cmsbuild, please test

Should compile now...

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31771/console Started: 2018/11/20 19:17

[cmsbuild]

+1
Tested at: e3e1d31
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25294/31771/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25294/31771/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013110
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1