Regression tests update for new boost serialisation change #25318
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25318/7343 |
|
A new Pull Request was created by @ggovi for master. It involves the following packages: CondCore/CondDB @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
db-approved
fully-signed
and removed
db-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| 'CMSSW_8_0_26' : [ ('slc6_amd64_gcc530', 'ref8026-s6530.db')], | ||
| 'CMSSW_7_6_6' : [ ('slc6_amd64_gcc493', 'ref766-s6493.db')], | ||
| writers = { 'CMSSW_9_0_1' : [ ('slc6_amd64_gcc630', 'ref901-s6630.db')], | ||
| 'CMSSW_8_1_0' : [ ('slc6_amd64_gcc530', 'ref750-s6530.db'),('slc6_amd64_gcc600', 'ref750-s600.db')], |
There was a problem hiding this comment.
@ggovi for my understanding, why this change compared to the previous version where both 8_0_26 and 8_1_0 were appearing with gcc530?
There was a problem hiding this comment.
901 and 810 makes more sense since they are respectively the first release built with gcc630 and gcc530. I honestly don't remember why we had the 8_0_26, I suspect was simply taken the release used to develop the test.
| # } | ||
|
|
||
| # Boost 1.67 [No reference release yet...] | ||
| readers = { |
There was a problem hiding this comment.
@ggovi so at present this just picks the current architecture of the used build, am I correct?
There was a problem hiding this comment.
yes, there is no full release yet available as a reader, there will be one after a full 10_4 will be available.
|
@ggovi could you please clarify about the couple of minor comments I had? |
|
+1 |
Condition Database:
Update for regression test to check compatibility of boost serialisation across versions
Reader list is empty, waiting for the (10_4?) reference release
SELF is the only readers ( no failure anymore )
Writer list has been cleaned up