-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception to action table lifetime #2542
Fix exception to action table lifetime #2542
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_0_X. Fix exception to action table lifetime It involves the following packages: Mixing/Base @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
Hello, while this fix is pending for 7_0_0 patch, would it worse to make PR for 7_1_X? |
Pull request 2595 issued for this fix in 7_1_X, at the request of civanich |
+1 |
Fix exception to action table lifetime
updates the tag for L1Trigger-L1TMuon data
This is a purely technical fix for a segmentation fault observed by Mike Hildreth when running workflows using data premixing.
An ExceptionToActionTable object is used to determine the course of action after an exception is caught.
Unfortunately, in the class that handles processing premixed data, an ExceptionToActionTable was constructed as a temporary on the stack whose lifetime was over before it was used.
This fix allocates it on the heap, held by a std::unique_ptr, making it's lifetime the same as the containing class.
This problem does not exist prior to 7_0_X as the affected code was new for 7_0_X.