Prepare for concurrent IOVs, L1ConfigOnlineProdBase

[wddgit]

This PR changes the return type of "produce" functions in ESProducers from shared_ptr to unique_ptr. This will help as we migrate towards running multiple IOVs concurrently, because ESProducers that actually share and reuse the memory need special treatment to work properly when multiple IOVs are processed concurrently. In all the cases modified here, the memory is not actually shared and reused. A unique_ptr will work just as well as a shared_ptr. By making this change, it makes it easier now and in the future to identify and take special care of the ESProducers that actually do share and reuse memory, because there are not actually very many of them. In addition, performance is slightly better with unique_ptr's than shared_ptr's.

This PR modifies L1ConfigOnlineProdBase and L1ConfigOnlineProdBaseExt and all the ESProducers that inherit from them.

(Note that previously PR #25037 was rejected and closed, then split into 3 different PRs. The first two of those PRs included all the changes in CondCore and have now already been merged. This is the 3rd of those PRs and includes only the changes from that PR outside CondCore. But other than that, it is the same as the original PR)

There is also a little bit of cleanup, like deleting unused "using" statements around the lines of code modified. And also some unrelated changes added by "scram b code-checks".

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25464/7555

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

CondTools/L1Trigger
CondTools/L1TriggerExt
L1TriggerConfig/CSCTFConfigProducers
L1TriggerConfig/DTTrackFinder
L1TriggerConfig/GMTConfigProducers
L1TriggerConfig/GctConfigProducers
L1TriggerConfig/L1GtConfigProducers
L1TriggerConfig/L1ScalesProducers
L1TriggerConfig/L1TConfigProducers
L1TriggerConfig/RCTConfigProducers
L1TriggerConfig/RPCTriggerConfig

@ggovi, @rekovic, @cmsbuild, @thomreis, @nsmith- can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32108/console Started: 2018/12/10 23:51

[cmsbuild]

+1
Tested at: 2d4f54c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25464/32108/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25464/32108/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3136422
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3136217
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[ggovi]

+1

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1