Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta R overlap filter for Candidates #2614

Merged
merged 2 commits into from
Mar 10, 2014

Conversation

olivito
Copy link
Contributor

@olivito olivito commented Feb 24, 2014

Adds a filter that runs on a collection of Cands and removes those that overlap in deltaR with another collection. Also adds dictionary for output of this module when running on PFCandidates.

The use case is for L3 muons in HLT paths with PF iso, which are seen to occasionally overlap with PF Hadrons. Hopefully going to be a temporary fix until the PF behavior there is fully understood.

The implementation was discussed on the physTools hn:
https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3163/1/1/1/1/1/2/1/1/1.html

Would also like to backport this to 70X if possible.

@olivito olivito restored the deltaR_filter branch February 24, 2014 09:59
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @olivito (Dominick Olivito) for CMSSW_7_1_X.

Delta R overlap filter for Candidates

It involves the following packages:

CommonTools/UtilAlgos
DataFormats/ParticleFlowCandidate

@nclopezo, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@anton-a
Copy link

anton-a commented Feb 27, 2014

+1

@olivito
Copy link
Contributor Author

olivito commented Mar 8, 2014

I see this is still "analysis-pending." Could the responsibles please check this request and either comment or approve it?

@monttj
Copy link
Contributor

monttj commented Mar 9, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 10, 2014
DataFormats -- Delta R overlap filter for Candidates
@nclopezo nclopezo merged commit d78c9ab into cms-sw:CMSSW_7_1_X Mar 10, 2014
@nclopezo nclopezo added this to the CMSSW_7_1_0_pre5 milestone Mar 10, 2014
@nclopezo nclopezo removed this from the CMSSW_7_1_0_pre4 milestone Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants