Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCal Validation Plots #26264

Merged
merged 3 commits into from Mar 31, 2019
Merged

HGCal Validation Plots #26264

merged 3 commits into from Mar 31, 2019

Conversation

jingyucms
Copy link
Contributor

PR description:

This PR adds TOT plots for HGCal Digi validation, and it also includes some minor changes of the histogram names/scales in the HGCal validation codes.

PR validation:

The changes have been run in workflow 27434.0, 27634.0, and 27634.99 and produce plots for example in https://indico.cern.ch/event/801871/contributions/3337371/attachments/1804302/2944004/PreMixingValidation_update.pdf page 4.

if this PR is a backport please specify the original PR:

No need to backport at this moment.

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26264/8939

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jingyucms (Jingyu Zhang) for master.

It involves the following packages:

Validation/HGCalValidation

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @rovere, @lgray, @cseez, @bsunanda, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@@ -215,8 +222,11 @@ void HGCalDigiValidation::analyze(const edm::Event& iEvent,
const HGCSample& hgcSample = it.sample(SampleIndx_);
uint16_t gain = hgcSample.toa();
uint16_t adc = hgcSample.data();
double charge = adc*gain;
digiValidation(detId, geom0, layer, adc, charge);
//double charge = adc*gain;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what motivates this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding, I don't think energy weighted TOA is used in the simulation/reconstruction. So I simply change it to TOA. Let me know if I misunderstood.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amartelli @Saptaparna can you take a look and confirm if this makes sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kpedro88 @jingyucms,
I agree that adc*toa is not interesting and not used.
Instead having a plot dedicated to the ToA is very useful.

thanks for this

charge_.at(ilayer)->Fill(hinfo.charge);
DigiOccupancy_XY_.at(ilayer)->Fill(hinfo.x, hinfo.y);
ADC_.at(ilayer)->Fill(hinfo.adc);
//charge_.at(ilayer)->Fill(hinfo.charge);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this histogram removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original histogram is filling the TOA information. So I just renamed the histogram from "charge_" to "TOA_".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then please delete all commented-out lines of code in the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done removing commented-out lines.

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33801/console Started: 2019/03/27 16:11

@Saptaparna
Copy link
Contributor

Saptaparna commented Mar 27, 2019 via email

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26264/8950

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33805/console Started: 2019/03/27 17:14

@cmsbuild
Copy link
Contributor

Pull request #26264 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26264/33805/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114657
  • DQMHistoTests: Total failures: 298
  • DQMHistoTests: Total nulls: 172
  • DQMHistoTests: Total successes: 3113990
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4204.085 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 21234.0,... ): 1189.618 KiB HGCAL/HGCalDigisV
  • DQMHistoSizes: changed ( 21234.0,... ): 81.250 KiB HGCAL/HGCalRecHitsV
  • DQMHistoSizes: changed ( 27434.0 ): 1556.099 KiB HGCAL/HGCalDigisV
  • DQMHistoSizes: changed ( 27434.0 ): 106.250 KiB HGCAL/HGCalRecHitsV
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6408bcb into cms-sw:master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants