-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HGCal Validation Plots #26264
HGCal Validation Plots #26264
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26264/8939
|
A new Pull Request was created by @jingyucms (Jingyu Zhang) for master. It involves the following packages: Validation/HGCalValidation @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -215,8 +222,11 @@ void HGCalDigiValidation::analyze(const edm::Event& iEvent, | |||
const HGCSample& hgcSample = it.sample(SampleIndx_); | |||
uint16_t gain = hgcSample.toa(); | |||
uint16_t adc = hgcSample.data(); | |||
double charge = adc*gain; | |||
digiValidation(detId, geom0, layer, adc, charge); | |||
//double charge = adc*gain; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what motivates this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my understanding, I don't think energy weighted TOA is used in the simulation/reconstruction. So I simply change it to TOA. Let me know if I misunderstood.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amartelli @Saptaparna can you take a look and confirm if this makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kpedro88 @jingyucms,
I agree that adc*toa is not interesting and not used.
Instead having a plot dedicated to the ToA is very useful.
thanks for this
charge_.at(ilayer)->Fill(hinfo.charge); | ||
DigiOccupancy_XY_.at(ilayer)->Fill(hinfo.x, hinfo.y); | ||
ADC_.at(ilayer)->Fill(hinfo.adc); | ||
//charge_.at(ilayer)->Fill(hinfo.charge); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this histogram removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original histogram is filling the TOA information. So I just renamed the histogram from "charge_" to "TOA_".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, then please delete all commented-out lines of code in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done removing commented-out lines.
please test |
The tests are being triggered in jenkins. |
Yes, this is something I am working on.
…On Wed, Mar 27, 2019, 10:23 AM amartelli ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Validation/HGCalValidation/plugins/HGCalDigiValidation.cc
<#26264 (comment)>:
> @@ -215,8 +222,11 @@ void HGCalDigiValidation::analyze(const edm::Event& iEvent,
const HGCSample& hgcSample = it.sample(SampleIndx_);
uint16_t gain = hgcSample.toa();
uint16_t adc = hgcSample.data();
- double charge = adc*gain;
- digiValidation(detId, geom0, layer, adc, charge);
+ //double charge = adc*gain;
Hi @kpedro88 <https://github.com/kpedro88> @jingyucms
<https://github.com/jingyucms>,
I agree that adc*toa is not interesting and not used.
Instead having a plot dedicated to the ToA is very useful.
thanks for this
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26264 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFbqKIw9Ob9ztUAY4KTl998tHv0XDGD2ks5va4zigaJpZM4cMk6j>
.
|
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26264/8950
|
The tests are being triggered in jenkins. |
Pull request #26264 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds TOT plots for HGCal Digi validation, and it also includes some minor changes of the histogram names/scales in the HGCal validation codes.
PR validation:
The changes have been run in workflow 27434.0, 27634.0, and 27634.99 and produce plots for example in https://indico.cern.ch/event/801871/contributions/3337371/attachments/1804302/2944004/PreMixingValidation_update.pdf page 4.
if this PR is a backport please specify the original PR:
No need to backport at this moment.
Before submitting your pull requests, make sure you followed this checklist: