Adding E, R and Z ranges to CloseByParticleGun generator

[tonydp03]

PR description:

This pull request is made because we want to introduce a range in Energy, R and Z in the CloseByParticleGunProducer Workflow. Now in the configuration file the energy, R and Z ranges must be specified, while the ParticleGun will select a random Energy, R and Z in those ranges.
In addition, a working snippet is added in the Generators folder.

@felicepantaleo
@rovere

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26277/8960

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • Configuration/Generator/python/CloseByParticle_Photon_ERZRanges.py:
    • Added: ffc7762
    • Deleted: 13c537c

[cmsbuild]

A new Pull Request was created by @tonydp03 (Tony Di Pilato) for master.

It involves the following packages:

Configuration/Generator
IOMC/ParticleGuns

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[tonydp03]

The possibility to produce particle in a given window (in R and phi) has been added (now it's possible to have particles overlapping). The snippet has been modified properly has well.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26277/8973

• This PR adds an extra 32KB to repository

• Found files with invalid states:

  • Configuration/Generator/python/CloseByParticle_Photon_ERZRanges.py:
    • Added: 441e90e
    • Deleted: 21d0fc0

[cmsbuild]

Pull request #26277 was updated. @efeyazgan, @perrozzi, @civanch, @mdhildreth, @cmsbuild, @alberto-sanchez, @qliphy can you please check and sign again.

[alberto-sanchez]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33835/console Started: 2019/03/28 21:02

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26277/8990

• This PR adds an extra 32KB to repository

• Found files with invalid states:

  • Configuration/Generator/python/CloseByParticle_Photon_ERZRanges.py:
    • Added: 441e90e
    • Deleted: 21d0fc0

[cmsbuild]

Pull request #26277 was updated. @efeyazgan, @perrozzi, @civanch, @mdhildreth, @cmsbuild, @alberto-sanchez, @qliphy can you please check and sign again.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33858/console Started: 2019/03/29 19:04

[cmsbuild]

+1
Tested at: 18619a8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26277/33858/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26277/33858/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3134059
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3133861
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[alberto-sanchez]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1