Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip nonexistent branch checks in L1TGlobalUtilHelper #26328

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Apr 2, 2019

this is expected to resolve #26182
thanks @Dr15Jones for suggesting a solution.

some notes leading to the resolution are in #26182 (comment) and following

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26328/9035

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Apr 2, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33910/console Started: 2019/04/02 17:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26328/33910/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2019

@rekovic could you please check? This should fix an annoying problem (@slava77 thanks)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 6, 2019

@rekovic ping

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2019

+1

@rekovic
Copy link
Contributor

rekovic commented Apr 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit e2a0510 into cms-sw:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to read 2018D data using CMSSW_10_2_10
5 participants