Updates on DQMOffline ZCounting for ultra legacy reco #26355

davidwalter2 · 2019-04-04T11:40:31Z

PR description:

There are updates concerning the different configurations for the different years of the UL, these is implemented using era modifier. There are also cosmetic updates and functional updates on the module itself.

PR validation:

It was tested locally with the test file in /DQMOffline/Lumi/test/ZCounting_cfg.py for different years on thesingle muon primary dataset (where it is intended to run only).

…ing and disable electron Z counting

cmsbuild · 2019-04-04T11:41:01Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-04T11:46:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26355/9073

This PR adds an extra 36KB to repository

cmsbuild · 2019-04-04T11:47:24Z

A new Pull Request was created by @davidwalter2 for master.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
DQMOffline/Lumi

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

andrius-k · 2019-04-04T14:33:33Z

please test

cmsbuild · 2019-04-04T14:33:59Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33967/console Started: 2019/04/04 16:35

jfernan2 · 2019-04-04T15:39:39Z

Configuration/StandardSequences/python/Eras.py

@@ -61,6 +61,7 @@ def __init__(self):
                           'run2_nanoAOD_94XMiniAODv1', 'run2_nanoAOD_94XMiniAODv2', 'run2_nanoAOD_94X2016',
                           'run2_miniAOD_devel', 'run2_nanoAOD_102Xv1',
                           'hcalHardcodeConditions', 'hcalSkipPacker',
+                           'run2_zcount_2016','run2_zcount_2017','run2_zcount_2018',


This kind of additions are going to be needed as a general modification to treat Trigger paths in HLT for the Run2 years. Perhaps a more general name like "run2_HLTconditions_201X" could work for everybody otherwise we could end having every PAG/POG adding its own Modifier for the same use case: changes in HLT paths.
Just my two pence on this issue

cmsbuild · 2019-04-04T16:24:56Z

+1
Tested at: acec662
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26355/33967/summary.html

cmsbuild · 2019-04-04T16:25:01Z

Comparison job queued.

cmsbuild · 2019-04-04T17:34:09Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26355/33967/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3139747
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3139549
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

cmsbuild · 2019-04-12T13:33:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-12T13:41:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26355/9249

This PR adds an extra 40KB to repository
Found files with invalid states:
- Configuration/Eras/python/Modifier_run2_zcount_2016_cff.py:
  - Added: 2c39353
  - Deleted: 21f1128
- Configuration/Eras/python/Modifier_run2_zcount_2017_cff.py:
  - Added: 2c39353
  - Deleted: 21f1128
- Configuration/Eras/python/Modifier_run2_zcount_2018_cff.py:
  - Added: 2c39353
  - Deleted: 21f1128

cmsbuild · 2019-04-12T13:41:47Z

Pull request #26355 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @fabiocos, @davidlange6 can you please check and sign again.

fabiocos · 2019-04-12T18:08:47Z

please test

cmsbuild · 2019-04-12T18:09:23Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34183/console Started: 2019/04/12 20:10

cmsbuild · 2019-04-12T20:22:10Z

+1
Tested at: 80b040b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26355/34183/summary.html

cmsbuild · 2019-04-12T20:22:21Z

Comparison job queued.

cmsbuild · 2019-04-12T21:39:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26355/34183/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3140495
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3140297
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

fioriNTU · 2019-04-13T07:05:58Z

+1

fabiocos · 2019-04-14T16:59:46Z

DQMOffline/Lumi/test/ZCounting_cfg.py

 process.source = cms.Source("PoolSource",
                                fileNames = cms.untracked.vstring(
-'/store/data/Run2017B/SingleMuon/RECO/PromptReco-v1/000/297/218/00000/14C84999-6457-E711-AAE4-02163E0136E0.root'
+#'/store/data/Run2017B/SingleMuon/RECO/PromptReco-v1/000/297/218/00000/14C84999-6457-E711-AAE4-02163E0136E0.root'
+'file:/eos/cms/store/data/Run2018D/SingleMuon/AOD/22Jan2019-v2/110000/104D2C01-12D2-0742-BE61-897755323EDE.root'


@davidwalter2 "file:/eos/cms" should be dropped, the cfg as it is fails to run. Anyway by adjusting the string it runs. As this is a standalone example I will move forward with the integration.

fabiocos · 2019-04-14T17:00:41Z

+1

cmsbuild · 2019-04-14T17:01:10Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

david walter added 5 commits April 3, 2019 12:13

move trigger configuration into ZCounting_cff.py

fa558db

cosmetics: add axis labels and histogram titles for muon histograms

1641f75

add year specific configuration with era modifier

2c39353

mainly cosmetics: fix poor naming convention, fix poor histogram binn…

08b1330

…ing and disable electron Z counting

add 2d histograms for pileup corrections and background subtraction

acec662

cmsbuild added this to the CMSSW_10_6_X milestone Apr 4, 2019

cmsbuild added code-checks-pending comparison-pending dqm-pending operations-pending orp-pending pending-signatures tests-pending labels Apr 4, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 4, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 4, 2019

jfernan2 reviewed Apr 4, 2019

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Apr 4, 2019

cmsbuild added comparison-available and removed comparison-pending labels Apr 4, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 12, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 12, 2019

cmsbuild added tests-approved and removed tests-started labels Apr 12, 2019

cmsbuild added comparison-available and removed comparison-pending labels Apr 12, 2019

cmsbuild added dqm-approved and removed dqm-pending labels Apr 13, 2019

fabiocos reviewed Apr 14, 2019

View reviewed changes

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending orp-pending pending-signatures labels Apr 14, 2019

cmsbuild merged commit 3f12844 into cms-sw:master Apr 14, 2019

missirol mentioned this pull request May 23, 2019

updates to Top-HLT sequence in DQMOffline (backport of #26540) #26861

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates on DQMOffline ZCounting for ultra legacy reco #26355

Updates on DQMOffline ZCounting for ultra legacy reco #26355

davidwalter2 commented Apr 4, 2019

cmsbuild commented Apr 4, 2019

cmsbuild commented Apr 4, 2019

cmsbuild commented Apr 4, 2019

andrius-k commented Apr 4, 2019

cmsbuild commented Apr 4, 2019 •

edited

Loading

jfernan2 Apr 4, 2019

cmsbuild commented Apr 4, 2019

cmsbuild commented Apr 4, 2019

cmsbuild commented Apr 4, 2019

cmsbuild commented Apr 12, 2019

cmsbuild commented Apr 12, 2019

cmsbuild commented Apr 12, 2019

fabiocos commented Apr 12, 2019

cmsbuild commented Apr 12, 2019 •

edited

Loading

cmsbuild commented Apr 12, 2019

cmsbuild commented Apr 12, 2019

cmsbuild commented Apr 12, 2019

fioriNTU commented Apr 13, 2019

fabiocos Apr 14, 2019

fabiocos commented Apr 14, 2019

cmsbuild commented Apr 14, 2019

Updates on DQMOffline ZCounting for ultra legacy reco #26355

Updates on DQMOffline ZCounting for ultra legacy reco #26355

Conversation

davidwalter2 commented Apr 4, 2019

PR description:

PR validation:

cmsbuild commented Apr 4, 2019

cmsbuild commented Apr 4, 2019

cmsbuild commented Apr 4, 2019

andrius-k commented Apr 4, 2019

cmsbuild commented Apr 4, 2019 • edited Loading

jfernan2 Apr 4, 2019

Choose a reason for hiding this comment

cmsbuild commented Apr 4, 2019

cmsbuild commented Apr 4, 2019

cmsbuild commented Apr 4, 2019

cmsbuild commented Apr 12, 2019

cmsbuild commented Apr 12, 2019

cmsbuild commented Apr 12, 2019

fabiocos commented Apr 12, 2019

cmsbuild commented Apr 12, 2019 • edited Loading

cmsbuild commented Apr 12, 2019

cmsbuild commented Apr 12, 2019

cmsbuild commented Apr 12, 2019

fioriNTU commented Apr 13, 2019

fabiocos Apr 14, 2019

Choose a reason for hiding this comment

fabiocos commented Apr 14, 2019

cmsbuild commented Apr 14, 2019

cmsbuild commented Apr 4, 2019 •

edited

Loading

cmsbuild commented Apr 12, 2019 •

edited

Loading