-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid null reference in getTrackFromChargedHadron #26381
Avoid null reference in getTrackFromChargedHadron #26381
Conversation
Calling operator* on a edm:Ref can cause it to return a reference to a nullptr. This is not allowed in C++ which allows the compiler to remove checks. This lead to crashes when clang optimized the code. Getting a pointer instead avoids the problem.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26381/9130
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoTauTag/RecoTau @cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Calling operator* on a edm:Ref can cause it to return a reference to a nullptr. This is not allowed in C++ which allows the compiler to remove checks. This lead to crashes when clang optimized the
code. Getting a pointer instead avoids the problem.
PR validation:
Ran workflow 4.23 which was crashing under CMSSW_10_6_CLANG_X_2019-04-07-0000 but now
runs fine with this change.