-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Backport) Provide forward compatibility to HepMC::GenEvent reading #26422
(Backport) Provide forward compatibility to HepMC::GenEvent reading #26422
Conversation
A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_8_0_X. It involves the following packages: SimDataFormats/GeneratorProducts @alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
To provide forward compatibility to HepMC::GenEvent reading. This is used for ultra-legacy processing with 2016 (CMSSW_8_0) HLT.
PR validation:
CMSSW_8_0_X_2019-04-07-0000 with this PR on top
cmsDriver.py HLT --conditions 80X_mcRun2_asymptotic_2016_TrancheIV_v6 -s HLT:@frozen2016 --datatier GEN-SIM-DIGI-RAW-HLTDEBUG -n -1 --era Run2_2016 --eventcontent FEVTDEBUGHLT --filein file:step2.root --python step2a_HLT.py --fileout step2a.root --no_exec --customise_commands 'process.source.bypassVersionCheck = cms.untracked.bool(True)' --customise Configuration/DataProcessing/Utils.addMonitoring --outputCommand 'keep *_mix_*_*','keep *_genPUProtons_*_*' --inputCommand 'keep *','drop *_*_BMTF_*','drop *PixelFEDChannel*_*_*_*' --mc
if this PR is a backport please specify the original PR:
backport of #26211
Thx @Dr15Jones
Before submitting your pull requests, make sure you followed this checklist: