Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backport) Provide forward compatibility to HepMC::GenEvent reading #26422

Merged
merged 1 commit into from Apr 11, 2019

Conversation

srimanob
Copy link
Contributor

PR description:

To provide forward compatibility to HepMC::GenEvent reading. This is used for ultra-legacy processing with 2016 (CMSSW_8_0) HLT.

PR validation:

CMSSW_8_0_X_2019-04-07-0000 with this PR on top
cmsDriver.py HLT --conditions 80X_mcRun2_asymptotic_2016_TrancheIV_v6 -s HLT:@frozen2016 --datatier GEN-SIM-DIGI-RAW-HLTDEBUG -n -1 --era Run2_2016 --eventcontent FEVTDEBUGHLT --filein file:step2.root --python step2a_HLT.py --fileout step2a.root --no_exec --customise_commands 'process.source.bypassVersionCheck = cms.untracked.bool(True)' --customise Configuration/DataProcessing/Utils.addMonitoring --outputCommand 'keep *_mix_*_*','keep *_genPUProtons_*_*' --inputCommand 'keep *','drop *_*_BMTF_*','drop *PixelFEDChannel*_*_*_*' --mc

if this PR is a backport please specify the original PR:

backport of #26211
Thx @Dr15Jones

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_8_0_X.

It involves the following packages:

SimDataFormats/GeneratorProducts

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34123/console Started: 2019/04/10 14:57

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26422/34123/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 1044669
  • DQMHistoTests: Total failures: 942
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1043619
  • DQMHistoTests: Total skipped: 108
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -14 KiB( 14 files compared)
  • Checked 62 log files, 7 edm output root files, 15 DQM output files

@alberto-sanchez
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fdbcb59 into cms-sw:CMSSW_8_0_X Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants