-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have checkImportPermission work properly under python3 #26596
Conversation
python3 added additional calls in the stack track which are internal details to python. checkImportPermission now ignores those internal details and can work like it does in python2.
@davidlange6 FYI |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26596/9527
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: deed722 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testGroupSelection had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
PR description:
python3 added additional calls in the stack track which are internal details to python. checkImportPermission now ignores those internal details and can work like it does in python2.
PR validation:
Made sure the various
FWCore/Integration/test/importRestrictions*.py
configurations now work under python 3.