-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent simultaneous execution of Rivet modules #26597
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26597/9532
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
Code-format makes the PR hard to read now, please just see the first commit for the relevant changes: 37dd72d |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26597/9536
|
A new Pull Request was created by @intrepid42 (Markus Seidel) for master. It involves the following packages: GeneratorInterface/RivetInterface @alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26597/9596
|
Pull request #26597 was updated. @alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
I have tested manually a long nanoAOD workflow, and I confirm that the multi-threading issue seems solved by this fix. It would be great if this makes it to pre5. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Please backport this fix to 10_2_X. Thanks! |
+1 |
PR description:
Several nanoAod workflows crashed when multi-thread jobs were running both Rivet-based ParticleLevelProducer and HTXSRivetProducer.
This PR prevents Rivet-based modules to be executed at the same time.
PR validation:
Updated modules tested on Higgs and non-Higgs sample. All Rivet modules run together within a test job using 10 threads, no crash after 10k events (the old versions crashed after a few events).
RivetAnalyzer:
ParticleLevelProducer: Object output (dressed leptons etc.) is as expected.
HTXSRivetProducer: