print statement fixes and preserve integer division with python3 #26680
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26680/9642
|
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: DQMServices/FwkIO @andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test
… On May 7, 2019, at 11:56 AM, cmsbuild ***@***.***> wrote:
A new Pull Request was created by @davidlange6 (David Lange) for master.
It involves the following packages:
DQMServices/FwkIO
Validation/Geometry
@andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks.
@barvic, @vargasa, @rishabhCMS, @rovere, @rbartek this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.
cms-bot commands are listed here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
| print("\n*** Error, '%s' not registered as a valid components to monitor." % options.label) | ||
| print("Allowed components:", _ALLOWED_LABELS) | ||
| print() |
There was a problem hiding this comment.
I would say it can be fixed in another round
There was a problem hiding this comment.
this PR doesn't add the printout - it preserves current behavior.
There was a problem hiding this comment.
@davidlange6 yes, I agree, if the maintainers want to modify it it can be done in another round, no point in stopping the PR already approved for this
There was a problem hiding this comment.
No problem, I'll remove it in one of my open PRs
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Fixes failing unit test in DEVEL IBs - the Validation/Geometry unit tests will still fail as our root build does not yet have pyroot working with python3.