Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for l1 #26751

Merged
merged 1 commit into from
May 17, 2019
Merged

Running code-format for l1 #26751

merged 1 commit into from
May 17, 2019

Conversation

cmsbuild
Copy link
Contributor

Applying code-format for CMSSW category l1.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/211//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26751/9745

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 11, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/162/console Started: 2019/05/11 11:48

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

L1Trigger/CSCCommonTrigger
L1Trigger/DTSectorCollector
L1Trigger/DTTrigger
L1Trigger/GlobalCaloTrigger
L1Trigger/GlobalMuonTrigger
L1Trigger/GlobalTriggerAnalyzer
L1Trigger/L1GctAnalyzer
L1TriggerConfig/L1CSCTPConfigProducers
SimCalorimetry/HcalTrigPrimProducers

@cmsbuild, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dildick this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9db42/162/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-b9db42/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 131
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211629
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

@ggovi could you please have a look?

@fabiocos
Copy link
Contributor

@rekovic could you please have a look?

@smuzaffar smuzaffar modified the milestones: CMSSW_10_6_X, CMSSW_11_0_X May 14, 2019
#endif

unop (operator!,!)
unop (operator~,~)
unop(operator!, !) unop(operator~, ~)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar I am not sure whether this is really desired, as well as the other similar cases in this file, although there is no problem observed in the test

@fabiocos
Copy link
Contributor

+1

@rekovic it looks ok to me, in case please check and comment

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ac0e3e0 into master May 17, 2019
@smuzaffar smuzaffar deleted the code-format-l1-0143f8 branch May 31, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants