Running code-format for reconstruction #26947
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26947/9998
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @cmsbuild for master. It involves the following packages: DataFormats/MuonData @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| private: | ||
| template <class T> | ||
| class stats_t | ||
| : boost::arithmetic1< |
There was a problem hiding this comment.
This can certainly be improved: fix it by hand?
|
|
||
| if (trackdirection.mag2() < | ||
| float( | ||
| FLT_MIN)) { // in case of no track hypothesis assume a track from the origin through the center of the strip |
There was a problem hiding this comment.
The already seen issue with comment fields in the same line as the code (to be fixed by moving the comment into the previous line)
| const TkRadialStripTopology* rtop = | ||
| dynamic_cast<const TkRadialStripTopology*>(&stripdet->specificType().specificTopology()); | ||
| p.pitch_rel_err2 = | ||
| (rtop) |
There was a problem hiding this comment.
It was better as it was before the update
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
same question as in #26868: do we want to merge this now, or make the few manual fixes first? |
Similar comments were made already in a few already merged PRs and there the action for an update was deferred for later. |
|
+1 |
Applying code-format for CMSSW category reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/276//console
cms-bot has successfully run the following: