[RECONSTRUCTION] fixes needed to build cxxmodules #26958

smuzaffar · 2019-05-27T14:53:39Z

PR description:

Added missing dependencies in BuildFiles.
Cleanup unused include statements.

DataFormats/CaloRecHit/interface/CaloCluster.h:#include "DataFormats/Math/interface/Point3D.h"

DataFormats/EcalRecHit/interface/EcalUncalibratedRecHit.h:#include "DataFormats/EcalDigi/interface/EcalDataFrame.h"

DataFormats/EgammaReco/interface/BasicClusterFwd.h:#include "DataFormats/EcalRecHit/interface/EcalRecHitCollections.h"
DataFormats/EgammaReco/interface/PreshowerClusterShapeFwd.h:#include "DataFormats/EcalRecHit/interface/EcalRecHitCollections.h"
DataFormats/EgammaReco/interface/PreshowerClusterFwd.h:#include "DataFormats/EcalRecHit/interface/EcalRecHitCollections.h"

DataFormats/ParticleFlowCandidate/interface/PFCandidate.h:#include "DataFormats/MuonReco/interface/Muon.h"
DataFormats/ParticleFlowCandidate/interface/PFCandidate.h:#include "DataFormats/MuonReco/interface/MuonFwd.h"
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:#include "DataFormats/MuonReco/interface/Muon.h"

DataFormats/RecoCandidate/src/classes.h:#include "DataFormats/HcalRecHit/interface/HcalRecHitCollections.h"
DataFormats/RecoCandidate/src/classes.h:#include "DataFormats/HcalRecHit/interface/HcalRecHitDefs.h" 
DataFormats/RecoCandidate/interface/TrackAssociation.h:#include "SimDataFormats/TrackingAnalysis/interface/TrackingParticle.h"
DataFormats/RecoCandidate/interface/TrackAssociation.h:#include "SimDataFormats/TrackingAnalysis/interface/TrackingParticleFwd.h"

DataFormats/TrackReco/interface/DeDxHitInfo.h:#include "DataFormats/SiPixelCluster/interface/SiPixelCluster.h"

DataFormats/TrackerRecHit2D/interface/ClusterRemovalRefSetter.h:#include "FWCore/Framework/interface/ConsumesCollector.h"
DataFormats/TrackerRecHit2D/interface/ClusterRemovalRefSetter.h:#include "FWCore/Framework/interface/Event.h"

DataFormats/TrackingRecHit/interface/TrackingRecHit.h:#include "DataFormats/GeometryCommonDetAlgo/interface/GlobalError.h"
DataFormats/TrackingRecHit/interface/AlignmentPositionError.h:#include "DataFormats/GeometryCommonDetAlgo/interface/GlobalError.h"

cmsbuild · 2019-05-27T14:54:17Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-05-27T14:59:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26958/10006

This PR adds an extra 20KB to repository

cmsbuild · 2019-05-27T14:59:38Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/CaloRecHit
DataFormats/EcalRecHit
DataFormats/EgammaCandidates
DataFormats/EgammaReco
DataFormats/ParticleFlowCandidate
DataFormats/RecoCandidate
DataFormats/TrackReco
DataFormats/TrackerCommon
DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@VinInn, @Sam-Harper, @makortel, @jainshilpi, @cbernet, @rovere, @argiro, @gouskos, @hatakeyamak, @gpetruc, @lgray, @varuns23, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2019-05-27T15:14:48Z

please test

cmsbuild · 2019-05-27T15:15:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/534/console Started: 2019/05/27 17:16

cmsbuild · 2019-05-27T19:21:18Z

+1
Tested at: d43f523
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b153a2/534/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
067a360
3405700
6ab9424
39fdf6d
f08fec1
d4f63ec
389296d
5c7a7ef
3f0fd84
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26958/534/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26958/534/git-merge-result

cmsbuild · 2019-05-27T19:21:22Z

Comparison job queued.

cmsbuild · 2019-05-27T21:31:17Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b153a2/534/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3209232
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3208895
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2019-05-28T15:27:57Z

DataFormats/TrackerCommon/interface/ClusterSummary.h

@@ -43,7 +43,7 @@
 #include "DataFormats/SiStripDigi/interface/SiStripProcessedRawDigi.h"
 #include "DataFormats/Common/interface/DetSetVector.h"

-#include "DataFormats/SiStripDetId/interface/StripSubdetector.h"
+//#include "DataFormats/SiStripDetId/interface/StripSubdetector.h"


please drop the commented out line.

slava77 · 2019-05-31T13:39:14Z

@smuzaffar
Please follow up or comment on
#26958 (review)
Thank you.

cmsbuild · 2019-05-31T17:22:29Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

slava77 · 2019-06-01T03:28:12Z

@cmsbuild please test

cmsbuild · 2019-06-01T03:28:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/677/console Started: 2019/06/01 05:57

cmsbuild · 2019-06-01T07:40:59Z

+1
Tested at: 029bfa3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b153a2/677/summary.html

cmsbuild · 2019-06-01T07:41:02Z

Comparison job queued.

cmsbuild · 2019-06-01T11:58:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b153a2/677/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3210678
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3210343
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2019-06-01T15:33:07Z

+1

for #26958 029bfa3

technical
jenkins tests pass

cmsbuild · 2019-06-01T15:33:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-06-01T21:39:43Z

+1

[RECONSTRUCTION] fixes needed to build cxxmodules

d43f523

cmsbuild added this to the CMSSW_11_0_X milestone May 27, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 27, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels May 27, 2019

cmsbuild added tests-started and removed tests-pending labels May 27, 2019

cmsbuild added tests-approved and removed tests-started labels May 27, 2019

cmsbuild added comparison-available and removed comparison-pending labels May 27, 2019

slava77 reviewed May 28, 2019

View reviewed changes

remove unused include statement

029bfa3

cmsbuild removed code-checks-approved comparison-available tests-approved labels May 31, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels May 31, 2019

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jun 1, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 1, 2019

cmsbuild added tests-approved and removed tests-started labels Jun 1, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 1, 2019

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jun 1, 2019

cmsbuild added orp-approved and removed orp-pending labels Jun 1, 2019

cmsbuild merged commit c3a02bd into cms-sw:master Jun 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RECONSTRUCTION] fixes needed to build cxxmodules #26958

[RECONSTRUCTION] fixes needed to build cxxmodules #26958

smuzaffar commented May 27, 2019

cmsbuild commented May 27, 2019

cmsbuild commented May 27, 2019

cmsbuild commented May 27, 2019

smuzaffar commented May 27, 2019

cmsbuild commented May 27, 2019 •

edited

Loading

cmsbuild commented May 27, 2019

cmsbuild commented May 27, 2019

cmsbuild commented May 27, 2019

slava77 May 28, 2019

smuzaffar May 31, 2019

slava77 commented May 31, 2019

cmsbuild commented May 31, 2019

slava77 commented Jun 1, 2019

cmsbuild commented Jun 1, 2019 •

edited

Loading

cmsbuild commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

slava77 commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

fabiocos commented Jun 1, 2019

[RECONSTRUCTION] fixes needed to build cxxmodules #26958

[RECONSTRUCTION] fixes needed to build cxxmodules #26958

Conversation

smuzaffar commented May 27, 2019

PR description:

cmsbuild commented May 27, 2019

cmsbuild commented May 27, 2019

cmsbuild commented May 27, 2019

smuzaffar commented May 27, 2019

cmsbuild commented May 27, 2019 • edited Loading

cmsbuild commented May 27, 2019

cmsbuild commented May 27, 2019

cmsbuild commented May 27, 2019

slava77 May 28, 2019

Choose a reason for hiding this comment

smuzaffar May 31, 2019

Choose a reason for hiding this comment

slava77 commented May 31, 2019

cmsbuild commented May 31, 2019

slava77 commented Jun 1, 2019

cmsbuild commented Jun 1, 2019 • edited Loading

cmsbuild commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

slava77 commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

fabiocos commented Jun 1, 2019

cmsbuild commented May 27, 2019 •

edited

Loading

cmsbuild commented Jun 1, 2019 •

edited

Loading