Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running code-format for analysis-reconstruction #27072

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Running code-format for analysis-reconstruction #27072

merged 2 commits into from
Jun 4, 2019

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Jun 3, 2019

Applying code-format for CMSSW category analysis,reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/348//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 3, 2019

please test

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Jun 3, 2019
@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27072/10158

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 3, 2019 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/711/console Started: 2019/06/03 06:23

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 3, 2019

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

CommonTools/CandUtils
CommonTools/Clustering1D
CommonTools/PileupAlgos
CommonTools/Statistics
CommonTools/TriggerUtils
JetMETCorrections/JetCorrector
JetMETCorrections/Modules
JetMETCorrections/Objects
PhysicsTools/MXNet
RecoMET/METFilters

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @makortel, @mmarionncern, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @seemasharmafnal, @hqucms, @schoef, @mariadalfonso, @TaiSakuma, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 3, 2019

+1
Tested at: 6a63925
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ca07/711/summary.html

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ca07/711/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3210678
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3210343
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2019

+1

for #27072 6a63925

  • technical
  • jenkins tests pass

fabiocos
fabiocos reviewed Jun 4, 2019
View reviewed changes
CommonTools/TriggerUtils/interface/PrescaleWeightProvider.h

~PrescaleWeightProvider() {}
void initRun(const edm::Run& run,
const edm::EventSetup& setup); // to be called from the ED module's beginRun() method
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be fixed

fabiocos
fabiocos reviewed Jun 4, 2019
View reviewed changes
Copy link
Contributor

@fabiocos fabiocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santocch apart for a couple of things that can be fixed afterwards this PR looks ready to go. Please check it anyway

CommonTools/TriggerUtils/src/GenericTriggerEventFlag.cc
l1Gt_->getL1GtRunCache( event, setup, useL1EventSetup, useL1GtTriggerMenuLite ); // FIXME This can possibly go to initRun()

l1Gt_->getL1GtRunCache(
event, setup, useL1EventSetup, useL1GtTriggerMenuLite); // FIXME This can possibly go to initRun()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be fixed

@fabiocos
Copy link
Contributor

fabiocos commented Jun 4, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Jun 4, 2019

merge

@cmsbuild cmsbuild merged commit e1c54b7 into master Jun 4, 2019
@santocch
Copy link

santocch commented Jun 4, 2019

+1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 4, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@smuzaffar smuzaffar deleted the code-format-analysis-reconstruction-674046 branch June 7, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocos fabiocos fabiocos left review comments

Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@cmsbuild @slava77 @fabiocos @santocch