Changes in CTPPSRawToDigi for PPS Full simulation #27462

mundim · 2019-07-09T12:59:16Z

PR description:

Changes needed in EventFilter/CTPPSRawToDigi in order to implement the PPS Full Simulation. Only code is included in this PR, all the configuration files modifications will be left to be issued in the last PR. This PR is independent of any other as far as PPS is related.

PR validation:

scram b -j 8 code-checks
scram b -j 8 code-format
scram b runtests

and

runTheMatrix.py --job-reports -j 14 -s -l limited -i all --ibeos

with output:
30 9 4 1 1 0 0 0 0 tests passed, 3 21 5 0 0 0 0 0 0 failed

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

… simulation

cmsbuild · 2019-07-09T12:59:43Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-07-09T13:06:17Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10789

This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10789/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10789/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2019-07-09T13:27:40Z

The code-checks are being triggered in jenkins.

mundim · 2019-07-09T13:28:19Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10789
* This PR adds an extra 44KB to repository
Code check has found code style and quality issues which could be resolved by applying following patch(s)
* **code-format**:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10789/code-format.patch
  e.g. `curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10789/code-format.patch | patch -p1`
  You can also run `scram build code-format` to apply code format directly

It is run every rebase since CMSSW_10_6, do not understand why the code went back to an ugly format. Sorry.

cmsbuild · 2019-07-09T13:34:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10790

This PR adds an extra 52KB to repository

cmsbuild · 2019-07-09T13:34:39Z

A new Pull Request was created by @mundim for master.

It involves the following packages:

EventFilter/CTPPSRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @forthommel, @jan-kaspar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2019-07-09T13:50:32Z

please test

cmsbuild · 2019-07-09T13:51:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1369/console Started: 2019/07/09 15:51

cmsbuild · 2019-07-09T15:01:54Z

+1
Tested at: 90c62da
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fb5c4/1369/summary.html

cmsbuild · 2019-07-09T15:02:01Z

Comparison job queued.

EventFilter/CTPPSRawToDigi/interface/CTPPSElectronicIndex.h

cmsbuild · 2019-07-17T16:31:57Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10927

This PR adds an extra 56KB to repository
Found files with invalid states:
- EventFilter/CTPPSRawToDigi/interface/CTPPSElectronicIndex.h:
  - Added: aa63ce9
  - Modified: 90c62da, e37187c
  - Deleted: 3b69540

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10927/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10927/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2019-07-17T18:35:22Z

The code-checks are being triggered in jenkins.

mundim · 2019-07-17T18:36:21Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10927

* This PR adds an extra 56KB to repository

* Found files with invalid states:
  
  * EventFilter/CTPPSRawToDigi/interface/CTPPSElectronicIndex.h:
    
    * Added: [aa63ce9](https://github.com/cms-sw/cmssw/commit/aa63ce98c33a1c09bdb1104e88c962df3ba5d3fd)
    * Modified: [90c62da](https://github.com/cms-sw/cmssw/commit/90c62da458665df83adba9e86ecc3aa9facfa12b), [e37187c](https://github.com/cms-sw/cmssw/commit/e37187c7d3cdfc13d5e9b046c6a0000dfe28411e)
    * Deleted: [3b69540](https://github.com/cms-sw/cmssw/commit/3b69540d02aa53fd600db4bf1606370f21f40e8e)

Code check has found code style and quality issues which could be resolved by applying following patch(s)

* **code-format**:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10927/code-format.patch
  e.g. `curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10927/code-format.patch | patch -p1`
  You can also run `scram build code-format` to apply code format directly

Done, but I have to make a note: code-format was run and didn't trigger the problem at first in this file. I have noticed in the past some time (do not tracked down yet why) it doesn't work.

cmsbuild · 2019-07-17T18:42:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10931

This PR adds an extra 56KB to repository
Found files with invalid states:
- EventFilter/CTPPSRawToDigi/interface/CTPPSElectronicIndex.h:
  - Added: aa63ce9
  - Modified: 90c62da, e37187c
  - Deleted: 3b69540

cmsbuild · 2019-07-17T18:42:59Z

Pull request #27462 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

perrotta · 2019-07-17T20:53:44Z

please test

cmsbuild · 2019-07-17T20:54:12Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1514/console Started: 2019/07/17 22:55

cmsbuild · 2019-07-17T22:16:53Z

+1
Tested at: b97e985
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fb5c4/1514/summary.html

cmsbuild · 2019-07-17T22:16:56Z

Comparison job queued.

cmsbuild · 2019-07-17T23:46:01Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fb5c4/1514/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 2622600
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2622298
DQMHistoTests: Total skipped: 302
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

perrotta · 2019-07-18T04:47:44Z

+1

Additions in EventFilter/CTPPSRawToDigi are integrated as planned, in order to be used for the PPS digitization
Jenkins tests pass and show no differences

cmsbuild · 2019-07-18T04:48:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-07-19T20:34:58Z

+1

Modification needed in CTPPSRawToDigi in order to implemente PPS Full…

aa63ce9

… simulation

cmsbuild added this to the CMSSW_11_0_X milestone Jul 9, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 9, 2019

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 9, 2019

running again scram b code-format

90c62da

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 9, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 9, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 9, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 9, 2019

slava77 reviewed Jul 9, 2019

View reviewed changes

EventFilter/CTPPSRawToDigi/interface/CTPPSElectronicIndex.h Outdated Show resolved Hide resolved

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 17, 2019

Applying code-format changes to ElectronicIndex.h

b97e985

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 17, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 17, 2019

cmsbuild removed the tests-pending label Jul 17, 2019

cmsbuild removed the tests-started label Jul 17, 2019

cmsbuild removed the comparison-pending label Jul 17, 2019

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jul 18, 2019

cmsbuild added orp-approved and removed orp-pending labels Jul 19, 2019

cmsbuild merged commit 7f38934 into cms-sw:master Jul 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes in CTPPSRawToDigi for PPS Full simulation #27462

Changes in CTPPSRawToDigi for PPS Full simulation #27462

mundim commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

mundim commented Jul 9, 2019 •

edited

Loading

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

perrotta commented Jul 9, 2019

cmsbuild commented Jul 9, 2019 •

edited

Loading

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

mundim commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

perrotta commented Jul 17, 2019

cmsbuild commented Jul 17, 2019 •

edited

Loading

cmsbuild commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

perrotta commented Jul 18, 2019

cmsbuild commented Jul 18, 2019

fabiocos commented Jul 19, 2019

Changes in CTPPSRawToDigi for PPS Full simulation #27462

Changes in CTPPSRawToDigi for PPS Full simulation #27462

Conversation

mundim commented Jul 9, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

mundim commented Jul 9, 2019 • edited Loading

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

perrotta commented Jul 9, 2019

cmsbuild commented Jul 9, 2019 • edited Loading

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

cmsbuild commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

mundim commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

perrotta commented Jul 17, 2019

cmsbuild commented Jul 17, 2019 • edited Loading

cmsbuild commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

cmsbuild commented Jul 17, 2019

perrotta commented Jul 18, 2019

cmsbuild commented Jul 18, 2019

fabiocos commented Jul 19, 2019

mundim commented Jul 9, 2019 •

edited

Loading

cmsbuild commented Jul 9, 2019 •

edited

Loading

cmsbuild commented Jul 17, 2019 •

edited

Loading