-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in CTPPSRawToDigi for PPS Full simulation #27462
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10789
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
It is run every rebase since CMSSW_10_6, do not understand why the code went back to an ugly format. Sorry. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10790
|
A new Pull Request was created by @mundim for master. It involves the following packages: EventFilter/CTPPSRawToDigi @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10927
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
Done, but I have to make a note: code-format was run and didn't trigger the problem at first in this file. I have noticed in the past some time (do not tracked down yet why) it doesn't work. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27462/10931 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Changes needed in EventFilter/CTPPSRawToDigi in order to implement the PPS Full Simulation. Only code is included in this PR, all the configuration files modifications will be left to be issued in the last PR. This PR is independent of any other as far as PPS is related.
PR validation:
scram b -j 8 code-checks
scram b -j 8 code-format
scram b runtests
and
runTheMatrix.py --job-reports -j 14 -s -l limited -i all --ibeos
with output:
30 9 4 1 1 0 0 0 0 tests passed, 3 21 5 0 0 0 0 0 0 failed
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: