-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DQMOfflineCosmics_SecondStep_FakeHLT for Cosmics harvesting #27576
add DQMOfflineCosmics_SecondStep_FakeHLT for Cosmics harvesting #27576
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27576/10976
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Configuration/StandardSequences @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+operations |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
After the integration of PR #27467 I noticed that the logs of the harvesting step of several cosmics based workflows was flooded with messages of the type:
(message is stripped, it is several hundred lines long, see e.g. here ).
While apparently the cosmics workflows are running successfully, even the HARVESTING step, it is not clear to me what exactly is being run.
At any rate I've traced the issue in the lack of definition of the sequence
dqmHarvestingFakeHLT
inConfiguration/StandardSequences/python/HarvestingCosmics_cff.py
which is now created removing the HLT monitoring clients which cannot meaningfully in absence of an HLT menu.As a side comment, I tried to remove the offending sequences via:
e.g. as proposed here: https://github.com/cms-sw/cmssw/pull/27467/files#diff-8660299b2ade38cf3638eb31ccb685f6R104 but this appears not to work. I would be curious to understand what is the most economic approach.
PR validation:
Passes tests of a real data and 2018 Cosmics MC workflows:
and inspection of the harvesting step logs shows lack of warning messages.
if this PR is a backport please specify the original PR:
This PR is not a backport.
cc:
@mtosi