Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DQMOfflineCosmics_SecondStep_FakeHLT for Cosmics harvesting #27576

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 20, 2019

PR description:

After the integration of PR #27467 I noticed that the logs of the harvesting step of several cosmics based workflows was flooded with messages of the type:

dqmHarvestingFakeHLT is not a possible harvesting type. Available are ['FH_DR_GROUP', 'SusyPostProcessorSequence',  ....] 

(message is stripped, it is several hundred lines long, see e.g. here ).
While apparently the cosmics workflows are running successfully, even the HARVESTING step, it is not clear to me what exactly is being run.
At any rate I've traced the issue in the lack of definition of the sequence dqmHarvestingFakeHLT in
Configuration/StandardSequences/python/HarvestingCosmics_cff.py which is now created removing the HLT monitoring clients which cannot meaningfully in absence of an HLT menu.
As a side comment, I tried to remove the offending sequences via:

DQMOfflineCosmics_SecondStep_FakeHLT = cms.Sequence(DQMOfflineCosmics_SecondStep)
DQMOfflineCosmics_SecondStep_FakeHLT.remove(triggerOfflineDQMClient)
DQMOfflineCosmics_SecondStep_FakeHLT.remove(hltOfflineDQMClient)

e.g. as proposed here: https://github.com/cms-sw/cmssw/pull/27467/files#diff-8660299b2ade38cf3638eb31ccb685f6R104 but this appears not to work. I would be curious to understand what is the most economic approach.

PR validation:

Passes tests of a real data and 2018 Cosmics MC workflows:

runTheMatrix.py -l 4.22,7.2 --ibeos 

and inspection of the harvesting step logs shows lack of warning messages.

if this PR is a backport please specify the original PR:

This PR is not a backport.
cc:

@mtosi

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27576/10976

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/StandardSequences
DQMOffline/Configuration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @threus, @dgulhan, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 20, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1561/console Started: 2019/07/20 17:38

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-713c7c/1561/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2622537
  • DQMHistoTests: Total failures: 46
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2622189
  • DQMHistoTests: Total skipped: 302
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 15927.494 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 4.22,... ): 1016.263 KiB EcalBarrel/EBSummaryClient
  • DQMHistoSizes: changed ( 4.22,... ): 578.848 KiB EcalBarrel/EBPedestalOnlineClient
  • DQMHistoSizes: changed ( 4.22,... ): 558.576 KiB EcalBarrel/EBTimingClient
  • DQMHistoSizes: changed ( 4.22,... ): 514.605 KiB EcalBarrel/EBIntegrityClient
  • DQMHistoSizes: changed ( 4.22 ): 368.617 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 4.22,... ): 343.307 KiB EcalEndcap/EESummaryClient
  • DQMHistoSizes: changed ( 4.22,... ): 248.643 KiB EcalEndcap/EEPedestalOnlineClient
  • DQMHistoSizes: changed ( 4.22,... ): 239.330 KiB EcalEndcap/EETimingClient
  • DQMHistoSizes: changed ( 4.22,... ): 222.938 KiB RPC/AllHits
  • DQMHistoSizes: changed ( 4.22,... ): 219.861 KiB RPC/Muon
  • DQMHistoSizes: changed ( 4.22 ): ...
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@jfernan2
Copy link
Contributor

+1
Thanks @mmusich for this one!
Indeed the economic solutions is not working in this case to remove the HLT part..
I will recheck for other cases. Thank you!

@fabiocos
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7310d8a into cms-sw:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants