L1 track trigger TTTrack mods

[mdhildreth]

PR description:

Addition of data members representing digitized L1 Track Trigger Track. Add new accessors for TTTrack information. Preserve old interfaces for now.

PR validation:

Purely technical changes. The old interfaces remain for now. Note that the L1TrackTrigger track-finding code is not in a release yet.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27686/11285

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27686/11285/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27686/11285/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mdhildreth]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27686/11288

• This PR adds an extra 32KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1827/console Started: 2019/08/04 20:17

[cmsbuild]

A new Pull Request was created by @mdhildreth for master.

It involves the following packages:

DQM/SiOuterTracker
DataFormats/L1TrackTrigger

@benkrikler, @kmaeshima, @schneiml, @andrius-k, @kpedro88, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@rovere, @sviret this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 5198110
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17991f/1827/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2531/console Started: 2019/09/16 16:53

[cmsbuild]

+1
Tested at: 5700e88
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17991f/2531/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17991f/2531/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2957336
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2956994
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[jfernan2]

+1

[fabiocos]

@rekovic @benkrikler could you please check this update in L1 DataFormats?

[rekovic]

+1

[rekovic]

@fabiocos
This is all good. Please merge.

[fabiocos]

@kpedro88 I see the replies of @mdhildreth , what is your conclusion?
@mdhildreth when can we expect to clean this code without destroying the L1T analysis work outside CMSSW? I understand the argument, but I would like to understand its limits

[kpedro88]

+upgrade
Items to address in the future:

• follow CMS code rules for accessor functions
• remove or fix commented-out code blocks

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

with the caveat that some code cleaning must be done at a later moment