-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1 track trigger TTTrack mods #27686
L1 track trigger TTTrack mods #27686
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27686/11285
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27686/11288
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @mdhildreth for master. It involves the following packages: DQM/SiOuterTracker @benkrikler, @kmaeshima, @schneiml, @andrius-k, @kpedro88, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@rekovic @benkrikler could you please check this update in L1 DataFormats? |
+1 |
@fabiocos |
@kpedro88 I see the replies of @mdhildreth , what is your conclusion? |
+upgrade
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 with the caveat that some code cleaning must be done at a later moment |
PR description:
Addition of data members representing digitized L1 Track Trigger Track. Add new accessors for TTTrack information. Preserve old interfaces for now.
PR validation:
Purely technical changes. The old interfaces remain for now. Note that the L1TrackTrigger track-finding code is not in a release yet.