Jetid muon fraction fix

[knash]

PR description:

Upon investigation into the issue reported here:
https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3669.html

It seems that the muon fraction was not properly implemented for all jet types. This PR fixes the issue.
This affects the "lepveto" jetid value stored in NanoAOD.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27691/11293

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27691/11293/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27691/11293/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[perrotta]

@knash , you need to apply the code-checks in order to have this PR tested, and the review can start.
Please do so, or just let us know which are the plans for this PR

[perrotta]

By the way, is there any intention to backport to any other release?

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27691/11425

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @knash for master.

It involves the following packages:

PhysicsTools/SelectorUtils

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1999/console Started: 2019/08/13 14:08

[perrotta]

+1

• The implementation of the fix looks quite logical, and adds the missing muon fractions to the jet id's whenever missing
• Jenkins tests pass and reco output is unafffected
• The only visible difference is in the nanoAOD JetID outputs, which is expected: xpog will evaluate about it

[perrotta]

By the way (@fabiocos @smuzaffar): no external is really needed here. It was just added for the tests in order to allow the PR build on top of the latest IB

[fabiocos]

@perrotta yes, it was a temporary workaround waiting for next IB, thank you anyway for reminding

[perrotta]

@fgolf,@peruzzim please have a look and sign, if you think so.
(I asked for your signature because the fix applies on nanoAOD output and I wanted to be sure that you were aware of it; on the other hand this is a real fix, and I suppose you can approve it rather easily)

[peruzzim]

+xpog

As said, this is a real bugfix. Do we have plans for backport?

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1

[ahinzmann]

@peruzzim @knash Let's get this fix into the next Run2 MiniAOD starting soon?

[knash]

@ahinzmann Right! let me start the backport now -- 106, 102?

[srimanob]

@ahinzmann
What will be your target? 2016, and reminiaod of 2017 and 2018?

@fabiocos

[ahinzmann]

Well every NanoAOD production is affected, though the number of analyses is likely very small, and there is a way to work around it matching e.g. ak4 and ak8 jets. So this is a small improvement. Up to you what campaign shall take it into account.

[peruzzim]

Do I understand correctly that this only affects variables stored in NanoAOD? If so, I think we should prepare the backports and hold them until we update the rest of NanoAOD code for the next round of production. It is not far away in time, in this way we can update both things at the same time and avoid inconsistencies until then.