Added missing return statement in switch for SiStripPayloadInspectorHelper #27717
Conversation
…elper gcc 9 gave a warning that the case statement was falling through to the next statement. Looking at the git history showed that before the routine was returning a std::pair it returned a string and for the case in question it returned the value "undefined". This change now matches the earlier behavior.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27717/11338
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CondCore/SiStripPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@ggovi this looks a trivial bug fix to me, I will merge it in next IB |
|
+1 |
|
merge |
PR description:
gcc 9 gave a warning that the case statement was falling through to the next statement. Looking at the git history showed that before the routine was returning a std::pair it returned a string and for the case in question it returned the value "undefined". This change now matches the earlier behavior.
PR validation:
Tested compilation under a gcc 9 IB.
This change would only cause a results change if incorrect values are being passed to the routine which was modified.