-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly use default c'tor in muon DetId copy c'tors #27721
Conversation
The gcc 9 compiler was warning that inheriting class copy constructors were not calling the base class copy constructors. The code was doing that on purpose. To make that clear, the code now explicitly calls the default constructor for the base class.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27721/11342
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DataFormats/MuonDetId @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The gcc 9 compiler was warning that inheriting class copy constructors were not calling the base class copy constructors. The code was doing that on purpose. To make that clear, the code now explicitly calls the default constructor for the base class.
PR validation:
The code compiles using a gcc 9 IB.
This is a technical change (explicitly doing what the compiler was implicitly doing) and should not change results.