Phase2-hgx217 Convert DDHGCalModuleAlgo.cc to dd4hep

[bsunanda]

PR description:

Convert yet another algorithm (DDHGCalModuleAlgo) to DD4Hep format

PR validation:

Checked with cfg files in the area Geometry/HGCalCommonData/test/python

if this PR is a backport please specify the original PR:

Nothing special

[bsunanda]

@smuzaffar Please see why this PR is stuck

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27894/11683

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2250/console Started: 2019/08/29 00:04

[cmsbuild]

+1
Tested at: 588fb7a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2883df/2250/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2883df/2250/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[cvuosalo]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1