Cleanup of EgammaHLTAlgos/Producers

[guitargeek]

PR description:

Part of the occasional Egamma cleanup PRs.

As briefly discussed in #23743 (comment), there are many classes in RecoEgamma/EgammaHLTProduces that are outdated and in the queue for the Egamma cleanups.

This PR suggests 3 things:

1. Remove unused plugins in EgammaHLTProducers
2. Merge the .h and .cc files of the remaining plugins and put them into the plugin directory
3. Remove the RecoEgamma/EgammaHLTAlgos package since only two classes in that package are still used at this point:
   • EgammaHLTPixelMatchElectronAlgo: only used in EgammaHLTProducers/plugins anyway so it should just go there
   • EgammaHLTTrackIsolation: used not only in EgammaHLTProducers but also in DQMOffline/Trigger. As an isolation algo, it was moved to RecoEgamma/EgammaIsolationAlgos since both packages that use EgammaHLTTrackIsolation already depend on the EgammaIsolationAlgos package anyway.

PR validation:

CMSSW compiles and local matrix tests run.

if this PR is a backport please specify the original PR:

No backport intended.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27909/11716

• This PR adds an extra 76KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Utilities/ReleaseScripts/scripts/git-publish modified in PR(s): Removing the PhysicsTools/MVATrainer package #27888

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DQMOffline/Trigger
EventFilter/EcalRawToDigi
RecoEgamma/EgammaHLTAlgos
RecoEgamma/EgammaHLTProducers
RecoEgamma/EgammaIsolationAlgos
Utilities/ReleaseScripts

@perrotta, @smuzaffar, @andrius-k, @Dr15Jones, @kmaeshima, @fwyzard, @schneiml, @Martin-Grunewald, @cmsbuild, @jfernan2, @fioriNTU, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @battibass, @mtosi, @jainshilpi, @jhgoh, @argiro, @Martin-Grunewald, @calderona, @HuguesBrun, @wddgit, @lgray, @trocino, @varuns23, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2289/console Started: 2019/08/31 15:50

[cmsbuild]

+1
Tested at: 327b1ac
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f748f/2289/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f748f/2289/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2955700
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2955358
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[jfernan2]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2325/console Started: 2019/09/03 11:48

[cmsbuild]

+1
Tested at: d76fcdd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f748f/2325/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f748f/2325/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2955700
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2955358
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[jfernan2]

+1

[perrotta]

+1

• removal of unused HLT related code and cleaning of a few more is implemented as planned
• jenkins tests pass and show no differences, and give no hints of any remaining usage of the removed code

[Martin-Grunewald]

+1

[Dr15Jones]

+1
for Utilities/ReleaseScripts

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1